Uh oh!
There was an error while loading. Please reload this page.
test: remove obsolete TODO comments for fs.read - #2032
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Not using test_ca.pem in these files anymore. Using elipses.txt which has multibyte chars. Not clear what constitutes "large" but that can be a different ticket if elipses.txt etc. are insufficiently large.
trevnorris
commented
Jun 22, 2015
Contributor
LGTM |
1 similar comment
jbergstroem
commented
Jun 22, 2015
Member
LGTM |
Trott added a commit
that referenced
this pull request
Jun 23, 2015
Not using test_ca.pem in these files anymore. Using elipses.txt which has multibyte chars. Not clear what constitutes "large" but that can be a different ticket if elipses.txt etc. are insufficiently large. PR-URL: #2032 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Trott
commented
Jun 23, 2015
MemberAuthor
Merged in bdfeb79 |
mscdex pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
Not using test_ca.pem in these files anymore. Using elipses.txt which has multibyte chars. Not clear what constitutes "large" but that can be a different ticket if elipses.txt etc. are insufficiently large. PR-URL: nodejs#2032 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This was referenced Aug 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not using test_ca.pem in these files anymore.
Using elipses.txt which has multibyte chars.
Not clear what constitutes "large" but that
can be a different ticket if elipses.txt etc.
are insufficiently large.