Skip to content

fs: use isUint32 in isFd - #20330

Closed
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:fs_use_isUint32_in_isFd
Closed

fs: use isUint32 in isFd#20330
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:fs_use_isUint32_in_isFd

Conversation

@danbev

@danbevdanbev commented Apr 26, 2018

Copy link
Copy Markdown
Contributor

This commit updates the isFd function to call isUint32 instead of
doing the same thing. I was tempted to remove isFd and just use isUint32
instead but wanted to get some feedback from others regarding
readablity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
fs: use isUint32 in isFd
00ae096
This commit updates the isFd function to call isUint32 instead of
doing the same thing. I was tempted to remove isFd and just use isUint32
instead but wanted to get some feedback from others regarding
readablity.
@nodejs-github-botnodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Apr 26, 2018
@danbev

danbev commented Apr 26, 2018

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/14523/

BridgeAR
BridgeAR reviewed Apr 26, 2018
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not replace isFd with isUint32 in this case?

@danbev

danbev commented Apr 26, 2018

Copy link
Copy Markdown
ContributorAuthor

Should we not replace isFd with isUint32 in this case?

Yeah, I was thinking the same thing (mentioned in the commit message). I'd prefer that. I'll wait a little and if no one objects I'll update.

@tniessen

tniessen commented Apr 26, 2018

Copy link
Copy Markdown
Member

If you'd like to still call isFd, you could use const isFd = isUint32 to avoid the function declaration.

@danbev

danbev commented Apr 26, 2018

Copy link
Copy Markdown
ContributorAuthor

If you'd like to still call isFd, you could use const isFd = isUint32 to avoid the function declaration.

I'd like to just use isUint32, but I like what you suggested there if others disagree. Thanks!

@benjamingr

benjamingr commented Apr 26, 2018

Copy link
Copy Markdown
Member

I'm +1 on what @tniessen suggested - they do the same thing - but I like the fact isFd is explicit about what it does.

benjamingr
benjamingr approved these changes Apr 26, 2018
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in either case LGTM on the current code.

tniessen
tniessen approved these changes Apr 26, 2018
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM either way.

TimothyGu
TimothyGu approved these changes Apr 26, 2018
View reviewed changes

@TimothyGuTimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not a fan of exposing internal functions to userland. The PR in its current shape LGTM.

@BridgeAR

BridgeAR commented Apr 26, 2018

Copy link
Copy Markdown
Member

@TimothyGu that function is only used internally as far as I can tell.

@TimothyGu

TimothyGu commented Apr 26, 2018

Copy link
Copy Markdown
Member

Ah oops. In that case LGTM either way.

richardlau
richardlau approved these changes Apr 26, 2018
View reviewed changes

@richardlaurichardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep isFd as it more clearly indicates the intent (as opposed to implementation).

@danbev

danbev commented Apr 27, 2018

Copy link
Copy Markdown
ContributorAuthor

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/14537/

@BridgeARBridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 27, 2018
@BridgeAR

BridgeAR commented Apr 28, 2018

Copy link
Copy Markdown
Member

Landed in bdf0d9b 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 28, 2018
@danbev@BridgeAR
fs: point isFd to isUint32
bdf0d9b
This commit updates the isFd function to call isUint32 instead of
doing the same thing.
PR-URL: nodejs#20330
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@danbev@MylesBorins
fs: point isFd to isUint32
e45e5b8
This commit updates the isFd function to call isUint32 instead of
doing the same thing.
PR-URL: #20330
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 8, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@tniessentniessentniessen approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@danbev@tniessen@benjamingr@BridgeAR@TimothyGu@jasnell@joyeecheung@richardlau@nodejs-github-bot