Uh oh!
There was an error while loading. Please reload this page.
test: remove unnecessary strictEqual() argument from remoteClose() - #20343
Closed
dayloryanes wants to merge 1 commit into
Closed
test: remove unnecessary strictEqual() argument from remoteClose()#20343dayloryanes wants to merge 1 commit into
dayloryanes wants to merge 1 commit into
Conversation
Trott
approved these changes
Apr 26, 2018
Trott
commented
Apr 26, 2018
Member
richardlau
approved these changes
Apr 26, 2018
Trott
commented
Apr 26, 2018
Member
trivikr
approved these changes
Apr 27, 2018
cjihrig
approved these changes
Apr 27, 2018
jasnell
approved these changes
Apr 27, 2018
lpinca
approved these changes
Apr 27, 2018
BridgeAR
approved these changes
Apr 29, 2018
Trott
commented
Apr 29, 2018
Member
trivikr
commented
May 3, 2018
Member
Another CI-rerun for node-test-commit-windows-fanned https://ci.nodejs.org/job/node-test-commit-windows-fanned/17709/ |
trivikr
commented
May 3, 2018
Member
Landed in aa18e22 Congratulations @dayloryanes on your first commit in Node.js core! 🎉 🎉 🎉 |
trivikr pushed a commit
that referenced
this pull request
May 3, 2018
PR-URL: #20343 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
PR-URL: #20343 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
commented
May 5, 2018
Member
Landed is merged. we don't use the big green button to merge for a number of reasons. This will go out in an upcoming 10.x |
ContributorAuthor
Thank you @jasnell for the clarification. |
Merged
MylesBorins pushed a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20343 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the
remoteClose()test, removing the string literal message on the third argument fromassert.strictEqual(), allows for the value of agent.freeSockets[name] to get printed.make -j4 test(UNIX), orvcbuild test(Windows) passescc: @Trott