Uh oh!
There was an error while loading. Please reload this page.
build: always use BUILDTYPE binary to run JS tests - #20362
Conversation
joyeecheung
commented
Apr 27, 2018
cc @nodejs/build |
joyeecheung
commented
Apr 27, 2018
| test-check-deopts: all | ||
| $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=release --check-deopts parallel sequential | ||
| $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) --check-deopts parallel sequential |
There was a problem hiding this comment.
This change is also needed in vcbuild.bat. I think node-check-deopts might be the only one in vcbuild.bat that has --mode=release hard-coded. So just one line needs to change in vcbuild.bat I think.
There was a problem hiding this comment.
@Trott I don't think there is a equivalent of BUILDTYPE_LOWER in vcbuild.bat, the test_args are manipulated in a different way. With my limited knowledge of batch, I suspect node-check-deopts is running the tests twice and the first round can be replaced by adding --check-deopts to test_args, but that probably belongs to another PR.
joyeecheung
commented
May 6, 2018
CI before landing: https://ci.nodejs.org/job/node-test-pull-request/14684/ |
joyeecheung
commented
May 14, 2018
joyeecheung
commented
May 14, 2018
Landed in 657723e, thanks! |
PR-URL: #20362 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #20362 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes