Skip to content

tools: fix TypeError from test.py --time - #20368

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:testpytime
Closed

tools: fix TypeError from test.py --time#20368
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:testpytime

Conversation

@richardlau

@richardlaurichardlau commented Apr 27, 2018

Copy link
Copy Markdown
Member

Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.

Fixes: #20341

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau
tools: fix TypeError from test.py --time
1fcb189
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.
@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Apr 27, 2018
@richardlaurichardlau mentioned this pull request Apr 27, 2018
Closed
@richardlau

richardlau commented Apr 27, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/14550/

@richardlau

richardlau commented Apr 27, 2018

Copy link
Copy Markdown
MemberAuthor

CI is green (!).

@BridgeAR

BridgeAR commented Apr 29, 2018

Copy link
Copy Markdown
Member

@nodejs/build PTAL

@BridgeARBridgeAR added the build Issues and PRs related to build files or the CI. label Apr 29, 2018
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2018
@trivikr

trivikr commented May 3, 2018

Copy link
Copy Markdown
Member

Landed in ab15198

@trivikrtrivikr closed this May 3, 2018
trivikr pushed a commit that referenced this pull request May 3, 2018
@richardlau@trivikr
tools: fix TypeError from test.py --time
ab15198
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.
PR-URL: #20368Fixes: #20341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@richardlau@MylesBorins
tools: fix TypeError from test.py --time
f6d37f2
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.
PR-URL: #20368Fixes: #20341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@richardlau@MylesBorins
tools: fix TypeError from test.py --time
3912551
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.
PR-URL: #20368Fixes: #20341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@richardlau@MylesBorins
tools: fix TypeError from test.py --time
246c2d1
Calculated durations are timedelta objects but the FormatTime function
is expecting a number in seconds.
PR-URL: #20368Fixes: #20341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 17, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.testIssues and PRs related to the tests.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@richardlau@BridgeAR@trivikr@Trott@nodejs-github-bot