Uh oh!
There was an error while loading. Please reload this page.
build: check for different deprecation signatures - #20384
Closed
BridgeAR wants to merge 1 commit into
Closed
Conversation
Right now we strictly test for `DEP00XX`. We are already above that number of deprecations and it is better to have a wildcard for the first three numbers. Only the last character has to match the X to print a warning.
BridgeARforce-pushed
the
loose-deprecation-check
branch
from
April 28, 2018 17:35
69ac869 to
add86f4CompareBridgeAR
commented
Apr 29, 2018
MemberAuthor
Ping @nodejs/build |
Trott
approved these changes
Apr 29, 2018
cjihrig
approved these changes
Apr 30, 2018
trivikr
approved these changes
May 3, 2018
jasnell
approved these changes
May 4, 2018
addaleax
approved these changes
May 5, 2018
addaleax
commented
May 5, 2018
Member
Landed in c71b973 |
addaleax pushed a commit
that referenced
this pull request
May 5, 2018
Right now we strictly test for `DEP00XX`. We are already above that number of deprecations and it is better to have a wildcard for the first three numbers. Only the last character has to match the X to print a warning. PR-URL: #20384 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit
that referenced
this pull request
May 8, 2018
Right now we strictly test for `DEP00XX`. We are already above that number of deprecations and it is better to have a wildcard for the first three numbers. Only the last character has to match the X to print a warning. PR-URL: #20384 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins pushed a commit
that referenced
this pull request
May 8, 2018
Right now we strictly test for `DEP00XX`. We are already above that number of deprecations and it is better to have a wildcard for the first three numbers. Only the last character has to match the X to print a warning. PR-URL: #20384 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit
that referenced
this pull request
May 9, 2018
Right now we strictly test for `DEP00XX`. We are already above that number of deprecations and it is better to have a wildcard for the first three numbers. Only the last character has to match the X to print a warning. PR-URL: #20384 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we strictly test for
DEP00XX. We are already above thatnumber of deprecations and it is better to have a wildcard for the
first three numbers. Only the last character has to match the X to
print a warning.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes