Uh oh!
There was an error while loading. Please reload this page.
src: avoid std::make_unique - #20386
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Work around nodejs/build#1254, which effectively breaks stress test CI and CITGM, by avoiding `std::make_unique` for now. This workaround should be reverted once that issue is resolved. Refs: nodejs/build#1254
addaleax
commented
Apr 28, 2018
MemberAuthor
Wasn’t sure about whether to open this PR, but I have no idea how soon the build issue is resolved and I think we want at least CITGM to be available for now – please 👍 this comment if you agree with fast-tracking. |
MemberAuthor
Here’s a re-run of the stress test CI that I originally wanted to run, to be sure: Stress CI (master): https://ci.nodejs.org/job/node-stress-single-test/1827/ |
TimothyGu
approved these changes
Apr 28, 2018
mmarchini
approved these changes
Apr 29, 2018
addaleax
commented
Apr 29, 2018
MemberAuthor
Landed in 283a967 |
addaleax added a commit
that referenced
this pull request
Apr 29, 2018
Work around nodejs/build#1254, which effectively breaks stress test CI and CITGM, by avoiding `std::make_unique` for now. This workaround should be reverted once that issue is resolved. Refs: nodejs/build#1254 PR-URL: #20386 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
Work around nodejs/build#1254, which effectively breaks stress test CI and CITGM, by avoiding `std::make_unique` for now. This workaround should be reverted once that issue is resolved. Refs: nodejs/build#1254 PR-URL: #20386 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Merged
addaleax added a commit
to addaleax/node
that referenced
this pull request
Oct 24, 2018
This broke Travis CI. We have run into this problem with `std::make_unique` in the past, and opted to not use it for now, e.g. in nodejs#20386.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work around nodejs/build#1254, which
effectively breaks stress test CI and CITGM, by avoiding
std::make_uniquefor now.This workaround should be reverted once that issue is resolved.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes