Uh oh!
There was an error while loading. Please reload this page.
doc: add missing backticks in n-api.md - #20390
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
Codify types, variable names, and code fragments checking patterns I've managed to think of. Some nits were also fixed in passing (add missing periods, remove extra line breaks etc).
vsemozhetbyt
commented
Apr 28, 2018
ContributorAuthor
vsemozhetbyt
commented
Apr 28, 2018
ContributorAuthor
(Not sure if this can be fast-tracked with more than 200 lines diff, but as the changes are nits-only, |
tniessen
approved these changes
Apr 29, 2018
trivikr
approved these changes
Apr 29, 2018
gabrielschulhof
approved these changes
Apr 29, 2018
BridgeAR
approved these changes
Apr 29, 2018
vsemozhetbyt
commented
Apr 29, 2018
ContributorAuthor
Landed in 8809f8b |
vsemozhetbyt added a commit
that referenced
this pull request
Apr 29, 2018
Codify types, variable names, and code fragments checking patterns I've managed to think of. Some nits were also fixed in passing (add missing periods, remove extra line breaks etc). PR-URL: #20390 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
Codify types, variable names, and code fragments checking patterns I've managed to think of. Some nits were also fixed in passing (add missing periods, remove extra line breaks etc). PR-URL: #20390 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesCodify types, variable names, and code fragments checking patterns I've managed to think of.
Some nits were also fixed in passing (add missing periods, remove extra line breaks etc).
@nodejs/documentation, @nodejs/n-api, sorry for the big diff (it is easily reviewable though): it seems we are a bit (understandably) careless in this big and complicated doc.