doc: Updates the OpenSSL 'list-message-digest-algorithms' to the newer 'list digest-algorithms' by shobhitchittora · Pull Request #20400 · nodejs/node

shobhitchittora · 2018-04-29T10:26:15Z

Closes: #20385

documentation is changed or added
commit message follows [commit guidelines]

…er `list digest-algorithms`. Closes: nodejs#20385

vsemozhetbyt · 2018-04-29T10:46:57Z

 The `algorithm` is dependent on the available algorithms supported by the
 version of OpenSSL on the platform. Examples are `'sha256'`, `'sha512'`, etc.
-On recent releases of OpenSSL, `openssl list-message-digest-algorithms` will
+On recent releases of OpenSSL, `openssl list digest-algorithms` ( `openssl list-message-digest-algorithms` for older versions of OpenSSL ) will


Nit: we have a linter rule that requires wrapping long lines at 80 characters.

Thanks for the comment. Running make lint didn't show any errors for me. 👍🏻
Made the change.

Thank you. If I recall correctly, make lint only lints code files and code fragments in the docs, not the doc formatting.

Refs: nodejs#20400

shobhitchittora · 2018-04-29T11:12:27Z

@RichAyotte thanks for pointing it out. Somehow I missed that in the doc. 🤦‍♂️

vsemozhetbyt · 2018-04-29T11:29:37Z

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/620/

shobhitchittora · 2018-04-29T12:05:09Z

🎉🎉🎉🎉 CI completed. Any other changes or can we close this ?

vsemozhetbyt · 2018-04-29T12:08:27Z

As per our rules, we need to wait a bit)

vsemozhetbyt · 2018-04-29T12:11:12Z

Node.js Collaborators, please, add 👍 here to approve fast-tracking.

shobhitchittora · 2018-04-29T12:14:10Z

@vsemozhetbyt didn't know about that. This the first time I've read something like this for an OSS project. I can see the benefits of this, in not hurrying things up and really pushing for quality. Kudos! 👍🏻

vsemozhetbyt · 2018-04-29T12:19:51Z

If you have some time to read, there is our contributing guide start point :)

BridgeAR · 2018-04-29T13:30:29Z

 version of OpenSSL on the platform. Examples are `'sha256'`, `'sha512'`, etc.
-On recent releases of OpenSSL, `openssl list-message-digest-algorithms` will
+On recent releases of OpenSSL, `openssl list -digest-algorithms` ( 
+`openssl list-message-digest-algorithms` for older versions of OpenSSL ) will


Would you be so kind and remove the whitespace in the beginning and end of the bracket? And move the opening bracket to the second line, so it is nicer to read.

Done @BridgeAR.

Refs: nodejs#20400

shobhitchittora · 2018-05-03T10:18:25Z

@BridgeAR @vsemozhetbyt Anything more to do for this ?

vsemozhetbyt · 2018-05-03T10:38:03Z

cc @nodejs/crypto Can we have one LGTM for this change?

shigeki

LGTM.
openssl list-cipher-algorithms also needs to be changed to openssl list -cipher-algorithms.
Please submit an new PR.

vsemozhetbyt · 2018-05-03T14:28:34Z

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/654/

PR-URL: #20400Fixes: #20385 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

vsemozhetbyt · 2018-05-03T14:49:00Z

Sorry I have landed before the last commit: 6a24c0c

Can you please open another PR for the last commit?

shobhitchittora · 2018-05-03T14:50:12Z

@vsemozhetbyt I'll do that.
Also I'll open a new issue for tracking @shigeki suggestion.

vsemozhetbyt · 2018-05-03T14:51:29Z

Thank you!

PR-URL: #20400Fixes: #20385 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #20400Fixes: #20385 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

docs: Updates the OpenSSL list-message-digest-algorithms to the new…
c833e4d
…er `list digest-algorithms`. Closes: nodejs#20385

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 29, 2018

shobhitchittora changed the title ~~docs: Updates the OpenSSL list-message-digest-algorithms to the newer list digest-algorithms~~docs: Updates the OpenSSL 'list-message-digest-algorithms' to the newer 'list digest-algorithms'Apr 29, 2018

shobhitchittora changed the title ~~docs: Updates the OpenSSL 'list-message-digest-algorithms' to the newer 'list digest-algorithms'~~doc: Updates the OpenSSL 'list-message-digest-algorithms' to the newer 'list digest-algorithms'Apr 29, 2018

vsemozhetbyt reviewed Apr 29, 2018
View reviewed changes

shobhitchittora added 2 commits April 29, 2018 16:37

doc: moves the addition to a new line as per lint
476d04f
Refs: nodejs#20400

doc: adds '-' before digest-algorithms.
f61e7cf
Refs: nodejs#20400

vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2018

BridgeAR reviewed Apr 29, 2018
View reviewed changes

doc: removes extra space + moved addition to next line
de827fb
Refs: nodejs#20400

trivikr approved these changes May 1, 2018
View reviewed changes

tniessen approved these changes May 3, 2018
View reviewed changes

shigeki approved these changes May 3, 2018
View reviewed changes

doc: updates command at one more place Refs:nodejs#20400
1b6ad45

vsemozhetbyt pushed a commit that referenced this pull request May 3, 2018
doc: update cli flag in crypto.md
6a24c0c
PR-URL: #20400Fixes: #20385 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

vsemozhetbyt closed this May 3, 2018

shobhitchittora deleted the update-doc-openssl-list-digest-algos branch May 3, 2018 15:00

MylesBorins pushed a commit that referenced this pull request May 4, 2018
doc: update cli flag in crypto.md
2d26f55
PR-URL: #20400Fixes: #20385 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

vsemozhetbyt pushed a commit that referenced this pull request May 7, 2018
doc: update one more command in crypto.md
5efbe4c
PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

MylesBorins pushed a commit that referenced this pull request May 8, 2018
doc: update one more command in crypto.md
aef4f80
PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

MylesBorins mentioned this pull request May 8, 2018
v10.1.0 proposal #20606
Merged

MylesBorins pushed a commit that referenced this pull request May 8, 2018
doc: update cli flag in crypto.md
8b17e7a
PR-URL: #20400Fixes: #20385 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>

MylesBorins pushed a commit that referenced this pull request May 8, 2018
doc: update one more command in crypto.md
38323bc
PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

MylesBorins pushed a commit that referenced this pull request May 9, 2018
doc: update one more command in crypto.md
bea4ffc
PR-URL: #20500 Refs: #20400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Uh oh!

Uh oh!

Conversation

shobhitchittora commented Apr 29, 2018

Uh oh!

vsemozhetbytApr 29, 2018

Choose a reason for hiding this comment

Uh oh!

shobhitchittoraApr 29, 2018

Choose a reason for hiding this comment

Uh oh!

vsemozhetbytApr 29, 2018

Choose a reason for hiding this comment

Uh oh!

shobhitchittora commented Apr 29, 2018

Uh oh!

vsemozhetbyt commented Apr 29, 2018

Uh oh!

shobhitchittora commented Apr 29, 2018

Uh oh!

vsemozhetbyt commented Apr 29, 2018

Uh oh!

vsemozhetbyt commented Apr 29, 2018

Uh oh!

shobhitchittora commented Apr 29, 2018

Uh oh!

vsemozhetbyt commented Apr 29, 2018

Uh oh!

BridgeARApr 29, 2018

Choose a reason for hiding this comment

Uh oh!

shobhitchittoraApr 30, 2018

Choose a reason for hiding this comment

Uh oh!

shobhitchittora commented May 3, 2018

Uh oh!

vsemozhetbyt commented May 3, 2018

Uh oh!

shigeki left a comment

Choose a reason for hiding this comment

Uh oh!

vsemozhetbyt commented May 3, 2018

Uh oh!

vsemozhetbyt commented May 3, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shobhitchittora commented May 3, 2018

Uh oh!

vsemozhetbyt commented May 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

vsemozhetbyt commented May 3, 2018•
edited
Loading