Uh oh!
There was an error while loading. Please reload this page.
doc: add missing periods or colons - #20401
Closed
vsemozhetbyt wants to merge 2 commits into
Closed
Conversation
Some other formatting nits were fixed and some superfluous descriptions were simplified in passing.
vsemozhetbyt
commented
Apr 29, 2018
ContributorAuthor
Please, add 👍 here to approve fast-tracking. |
vsemozhetbyt
commented
Apr 29, 2018
ContributorAuthor
BridgeAR
approved these changes
Apr 29, 2018
| --> | ||
| Specify an alternative default TLS cipher list. (Requires Node.js to be built | ||
| with crypto support. (Default)) |
Member
There was a problem hiding this comment.
The Default here seems somewhat confusing.
ContributorAuthor
There was a problem hiding this comment.
Maybe this?
Specify an alternative default TLS cipher list. Requires Node.js to be built
with crypto support (default).gireeshpunathil
approved these changes
Apr 29, 2018
vsemozhetbyt
commented
Apr 29, 2018
ContributorAuthor
@BridgeAR, @gireeshpunathil Is the second fixup commit OK for you? CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/623/ |
BridgeAR
commented
Apr 29, 2018
Member
Still LG |
trivikr
approved these changes
Apr 29, 2018
cjihrig
approved these changes
Apr 30, 2018
vsemozhetbyt added a commit
that referenced
this pull request
May 2, 2018
Some other formatting nits were fixed and some superfluous descriptions were simplified in passing. PR-URL: #20401 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
vsemozhetbyt
commented
May 2, 2018
ContributorAuthor
Landed in 392d80a |
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
Some other formatting nits were fixed and some superfluous descriptions were simplified in passing. PR-URL: #20401 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesSome other formatting nits were fixed and some superfluous descriptions were simplified in passing.
cc @Trott