Uh oh!
There was an error while loading. Please reload this page.
doc: specify types of listener parameter - #20405
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.vsemozhetbyt
commented
Apr 29, 2018
ContributorAuthor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
commented
Apr 29, 2018
ContributorAuthor
4 tasks
lpinca
approved these changes
Apr 29, 2018
cjihrig
approved these changes
May 1, 2018
vsemozhetbyt added a commit
that referenced
this pull request
May 2, 2018
We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.
PR-URL: #20405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>vsemozhetbyt
commented
May 2, 2018
ContributorAuthor
Landed in aaca38a |
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.
PR-URL: #20405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesWe cannot manage with
{any}becausemessagecannot be ofSymbolorundefinedtypes.