test: do not swallow OpenSSL support error

[Trott]

All of the CI tests have OpenSSL enabled so the catch() block (gracefully swallowing the error if is not enabled) is unexercised.

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/74/

[mscdex]

So I guess this means we aren't or haven't been regularly testing building without openssl?

[Trott]

The CI came back all green, so yes, that would appear to be the case. I don't know if that whole "check for OpenSSL" part was from before crypto was firmly established in core, or if an issue should be opened to test alternate builds, or something else. But it seems like removing the error-swallowing makes sense, at least for the CI. If anything in tls fails, it seems the test should blow up, rather than be skipped. (So now it will blow up in the subsequent code in the test.)

[brendanashworth]

It isn't about the CI having OpenSSL all enabled or not (it may - I don't know), but the test is skipped regardless because of an above check. Looks like I missed this one in 999fbe9.

[jbergstroem]

@mscdex I ran a few builds some month ago without openssl support and had the test suite pass. I test every now and then as part of the gentoo iojs packaging as well.

[Trott]

@brendanashworth Ah, I see. So, this change purges some dead code, hooray and all that, but the other comments I made are not well-founded. Is that about right?

[brendanashworth]

@Trott seems right :-), LGTM.

[jbergstroem]

LGTM; should've removed this while adding the new crypto check.

[Trott]

Merged in 4d5089e