Skip to content

http2: reduce require calls in http2/core - #20422

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:http2_core_requires
Closed

http2: reduce require calls in http2/core#20422
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:http2_core_requires

Conversation

@danbev

@danbevdanbev commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

This commit removes unnecesary requires of http and internal/util in
http2/core.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
http2: reduce require calls in http2/core
c929963
This commit removes unnecesary requires of http and internal/util in
http2/core.js
@nodejs-github-botnodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Apr 30, 2018
@danbev

danbev commented Apr 30, 2018

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/14596/

@BridgeAR

BridgeAR commented Apr 30, 2018

Copy link
Copy Markdown
Member

-0 as this is mainly churn out of my perspective.

@danbev

danbev commented May 2, 2018

Copy link
Copy Markdown
ContributorAuthor

Landed in 557f570.

@danbevdanbev closed this May 2, 2018
@danbev
danbev deleted the http2_core_requires branch May 2, 2018 06:46
danbev added a commit to danbev/node that referenced this pull request May 2, 2018
@danbev
http2: reduce require calls in http2/core
557f570
This commit removes unnecesary requires of http and internal/util in
http2/core.js
PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@danbev@MylesBorins
http2: reduce require calls in http2/core
42bbaa3
This commit removes unnecesary requires of http and internal/util in
http2/core.js
PR-URL: #20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 8, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
@danbev@kjin
http2: reduce require calls in http2/core
27a337a
This commit removes unnecesary requires of http and internal/util in
http2/core.js
PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Sep 11, 2018
@danbev@kjin
http2: reduce require calls in http2/core
1f55a39
This commit removes unnecesary requires of http and internal/util in
http2/core.js
PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Sep 19, 2018
@danbev@kjin
http2: reduce require calls in http2/core
1b7d030
This commit removes unnecesary requires of http and internal/util in
http2/core.js
PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@danbev@kjin
http2: reduce require calls in http2/core
d9efc87
This commit removes unnecesary requires of http and internal/util in
http2/core.js
PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@danbev@BethGriggs
http2: reduce require calls in http2/core
74192dd
This commit removes unnecesary requires of http and internal/util in
http2/core.js
Backport-PR-URL: #22850
PR-URL: #20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@trivikrtrivikrtrivikr approved these changes
+2 more reviewers
@apapirovskiapapirovskiapapirovski approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@danbev@BridgeAR@apapirovski@lpinca@TimothyGu@trivikr@nodejs-github-bot