http2: rename http2_state class to Http2State

[danbev]

This commit renames the http2_state class to follow the guidelines in
CPP_STYLE_GUIDE.md.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/14598/

[addaleax]

SGTM, but maybe we should note in the style guide that for C-like plain structs we tend to follow snake_case style, e.g. struct http2_state_internal?

[danbev]

SGTM, but maybe we should note in the style guide that for C-like plain structs we tend to follow snake_case style, e.g. struct http2_state_internal?

Sounds good, I'll add a suggestion for this. Thanks.

[danbev]

node-test-commit-arm-fanned failure looks unrelated

console output:

09:53:55 not ok 303 sequential/test-net-GH-550409:53:55 ---09:53:55 duration_ms: 240.3909:53:55 severity: fail09:53:55 exitcode: -1509:53:55 stack: |-09:53:55 timeout09:53:55 SERVER 1>listening09:53:55 SERVER 2>NET 24180: setupListenHandle 127.0.0.1 12346 4 false undefined09:53:55 SERVER 2>NET 24180: setupListenHandle: create a handle09:53:55 SERVER 2>NET 24180: bind to 127.0.0.109:53:55 CLIENT 2>NET 24186: createConnection [ { host: '127.0.0.1', port: 12346 },09:53:55 CLIENT 2> [Function],09:53:55 CLIENT 2> [Symbol(normalizedArgs)]: true ]09:53:55 CLIENT 2>NET 24186: pipe false undefined09:53:55 SERVER 2>NET 24180: onconnection09:53:55 CLIENT 2>NET 24186: afterConnect09:53:55 SERVER 2>NET 24180: _read09:53:55 SERVER 2>NET 24180: Socket._read readStart09:53:55 SERVER 2>NET 24180: SERVER _emitCloseIfDrained09:53:55 SERVER 2>NET 24180: SERVER handle? false connections? 109:53:55 CLIENT 2>NET 24186: destroy09:53:55 CLIENT 2>NET 24186: close09:53:55 CLIENT 2>NET 24186: close handle09:53:55 CLIENT 2>NET 24186: _read09:53:55 CLIENT 2>NET 24186: _read wait for connection09:53:55 CLIENT 2>NET 24186: emit close09:53:55 ...

node-test-linux-linked-openssl110 failure looks unrelated

console output:

09:52:55 not ok 174 parallel/test-child-process-spawnsync-kill-signal09:52:55 ---09:52:55 duration_ms: 0.69109:52:55 severity: fail09:52:55 exitcode: 109:52:55 stack: |-09:52:55 assert.js:7709:52:55 throw new AssertionError(obj);09:52:55 ^09:52:55 09:52:55 AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:09:52:55 + expected - actual09:52:55 09:52:55 - 'SIGSEGV'09:52:55 + 'SIGTERM'09:52:55 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_openssl110_x64/test/parallel/test-child-process-spawnsync-kill-signal.js:42:12)09:52:55 at Module._compile (internal/modules/cjs/loader.js:678:30)09:52:55 at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)09:52:55 at Module.load (internal/modules/cjs/loader.js:589:32)09:52:55 at tryModuleLoad (internal/modules/cjs/loader.js:528:12)09:52:55 at Function.Module._load (internal/modules/cjs/loader.js:520:3)09:52:55 at Function.Module.runMain (internal/modules/cjs/loader.js:719:10)09:52:55 at startup (internal/bootstrap/node.js:229:19)09:52:55 at bootstrapNodeJSCore (internal/bootstrap/node.js:577:3)09:52:55 ...

[addaleax]

Thanks! Landed in 2c5b94f, c8f8847