Skip to content

Revert "stream: prevent 'end' to be emitted after 'error'" - #20449

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:revert-20104
Closed

Revert "stream: prevent 'end' to be emitted after 'error'"#20449
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:revert-20104

Conversation

@mscdex

@mscdexmscdex commented May 1, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #20334

CI: https://ci.nodejs.org/job/node-test-pull-request/14609/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label May 1, 2018
@mscdex

mscdex commented May 1, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

FWIW I'm targeting master here because I think we need a better plan on how to more easily transition existing code (e.g. replacing existing uses of 'end' with some other event that acts as a "error or not" end event, such as 'close' or similar as I suggested in the referenced issue).

@mscdex

mscdex commented May 1, 2018

Copy link
Copy Markdown
ContributorAuthor

/cc @nodejs/streams

@mcollina

mcollina commented May 1, 2018

Copy link
Copy Markdown
Member

I’m -1 to land this on master. I’m +1 to land this on node 10.0.0.

@mscdex

mscdex commented May 4, 2018

Copy link
Copy Markdown
ContributorAuthor

/cc @nodejs/collaborators

mcollina
mcollina approved these changes May 4, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll redo the PR.

Ref: #20503.

@mcollinamcollina mentioned this pull request May 4, 2018
Closed
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2018
@addaleax

addaleax commented May 6, 2018•
edited
Loading

Copy link
Copy Markdown
Member

@mcollina I’d really really like to not get in a habit of reverting commits only on release branches – if there is breakage that is significant enough to revert something, then we should try to keep master clear of that as well imo.

Edit: Removing the author ready label because there was a -1 on landing this on its target branch.

@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2018
@mscdex

mscdex commented May 7, 2018

Copy link
Copy Markdown
ContributorAuthor

@mcollina I'm confused a bit with your explicit approval. Does that mean you are no longer -1 on landing this on master?

@mcollina

mcollina commented May 7, 2018

Copy link
Copy Markdown
Member

Yes exactly. I’ll resend the PR as soon as this land, but we need to revert it in 10 (it seems this causes some other issues). I agree this was rushed in.

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 7, 2018
@addaleax

addaleax commented May 7, 2018

Copy link
Copy Markdown
Member

Landed in 8f6ab9f

@addaleaxaddaleax closed this May 7, 2018
addaleax pushed a commit that referenced this pull request May 7, 2018
@mscdex@addaleax
Revert "stream: prevent 'end' to be emitted after 'error'"
8f6ab9f
This reverts commit 0857790.
PR-URL: #20449Fixes: #20334
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ronag

ronag commented May 7, 2018

Copy link
Copy Markdown
Member

@addaleax re-open open v11?

@addaleax

addaleax commented May 7, 2018

Copy link
Copy Markdown
Member

@ronag As I understand it, @mcollina said that he’d open another fix for the original issue. Re-opening PRs doesn’t work always well with our release tooling, unfortunately.

mcollina added a commit to mcollina/node that referenced this pull request May 7, 2018
@mcollina
stream: prevent 'end' to be emitted after 'error'
e065b5b
This reverts commit 8f6ab9f.
This PR adds _readableState.errorEmitted and add the tracking of it.
Fixes: nodejs#6083
See: nodejs#20334
See: nodejs#20449
@mcollinamcollina mentioned this pull request May 7, 2018
Closed
4 tasks
@mcollina

mcollina commented May 7, 2018

Copy link
Copy Markdown
Member

Done in #20571.

@mscdex
mscdex deleted the revert-20104 branch May 7, 2018 12:37
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@mscdex@MylesBorins
Revert "stream: prevent 'end' to be emitted after 'error'"
c06821a
This reverts commit 0857790.
PR-URL: #20449Fixes: #20334
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@mscdex@MylesBorins
Revert "stream: prevent 'end' to be emitted after 'error'"
931408e
This reverts commit 0857790.
PR-URL: #20449Fixes: #20334
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request May 9, 2018
@mscdex@MylesBorins
Revert "stream: prevent 'end' to be emitted after 'error'"
4c4be85
This reverts commit 0857790.
PR-URL: #20449Fixes: #20334
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mscdex@mcollina@addaleax@ronag@lpinca@BridgeAR@nodejs-github-bot