Uh oh!
There was an error while loading. Please reload this page.
doc: multiple minor fixes to fs.md - #20450
Closed
Trott wants to merge 3 commits into
Closed
Conversation
Shorten the text about the `highWaterMark` value for the stream returned by `fs.createReadStream()`.
There is a paragraph explaining that `fs.write()` cannot write a substring of the provided string. It's not clear what `buffer` refers to in that paragraph or even what the purpose of the paragraph is. There's no suggestion elsewhere that `fs.write()` should be expected to have a substring feature. Remove the paragraph.
There is a paragraph about why the promise-based API uses `FileHandle` rather than a numeric `fd`. Unfortunately, the paragraph is a bit of word-salad. Edit it for clarity, grammar, and style.
Trott
commented
May 1, 2018
MemberAuthor
Trott
commented
May 1, 2018
MemberAuthor
👍 here if in favor of fast-tracking |
lpinca
approved these changes
May 1, 2018
vsemozhetbyt
approved these changes
May 1, 2018
cjihrig
approved these changes
May 1, 2018
tniessen
approved these changes
May 1, 2018
trivikr
approved these changes
May 1, 2018
jasnell
approved these changes
May 1, 2018
MemberAuthor
Landed in d3abb60...64a3765 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 1, 2018
Shorten the text about the `highWaterMark` value for the stream returned by `fs.createReadStream()`. PR-URL: nodejs#20450 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 1, 2018
There is a paragraph explaining that `fs.write()` cannot write a substring of the provided string. It's not clear what `buffer` refers to in that paragraph or even what the purpose of the paragraph is. There's no suggestion elsewhere that `fs.write()` should be expected to have a substring feature. Remove the paragraph. PR-URL: nodejs#20450 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 1, 2018
There is a paragraph about why the promise-based API uses `FileHandle` rather than a numeric `fd`. Unfortunately, the paragraph is a bit of word-salad. Edit it for clarity, grammar, and style. PR-URL: nodejs#20450 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
Shorten the text about the `highWaterMark` value for the stream returned by `fs.createReadStream()`. PR-URL: #20450 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
There is a paragraph explaining that `fs.write()` cannot write a substring of the provided string. It's not clear what `buffer` refers to in that paragraph or even what the purpose of the paragraph is. There's no suggestion elsewhere that `fs.write()` should be expected to have a substring feature. Remove the paragraph. PR-URL: #20450 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 4, 2018
There is a paragraph about why the promise-based API uses `FileHandle` rather than a numeric `fd`. Unfortunately, the paragraph is a bit of word-salad. Edit it for clarity, grammar, and style. PR-URL: #20450 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit:
Second commit:
Third commit:
Checklist