Uh oh!
There was an error while loading. Please reload this page.
doc: updates crypto doc with openssl list -cipher-algorithms - #20502
Closed
shobhitchittora wants to merge 2 commits into
Closed
doc: updates crypto doc with openssl list -cipher-algorithms#20502shobhitchittora wants to merge 2 commits into
shobhitchittora wants to merge 2 commits into
Conversation
| The `algorithm` is dependent on OpenSSL, examples are `'aes192'`, etc. On | ||
| recent OpenSSL releases, `openssl list-cipher-algorithms` will display the | ||
| available cipher algorithms. | ||
| recent OpenSSL releases, `openssl list -cipher-algorithms` |
Contributor
There was a problem hiding this comment.
Extra space after the comma)
| recent OpenSSL releases, `openssl list-cipher-algorithms` will display the | ||
| available cipher algorithms. | ||
| recent OpenSSL releases, `openssl list -cipher-algorithms` | ||
| (`openssl list-cipher-algorithms` for older versions of OpenSSL) will |
Contributor
There was a problem hiding this comment.
Extra space after the backtick here and in two other same lines)
shobhitchittoraforce-pushed
the
update-doc-openssl-list-cipher
branch
from
May 3, 2018 15:20
dfa96c0 to
36ab254Compareshobhitchittoraforce-pushed
the
update-doc-openssl-list-cipher
branch
from
May 3, 2018 15:21
36ab254 to
36beaf4Comparevsemozhetbyt
commented
May 3, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
commented
May 3, 2018
Contributor
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/656/ cc @nodejs/crypto |
Contributor
Either an appropriate issue should be referenced instead of #20501 or it should just be left out entirely. There is no need to create an issue just for the PR. |
tniessen
approved these changes
May 3, 2018
mscdex
commented
May 3, 2018
Contributor
Also, 'cypher' in the commit message should be 'cipher' |
shobhitchittora
commented
May 3, 2018
ContributorAuthor
@vsemozhetbyt can you please update the commit message ( |
trivikr
approved these changes
May 3, 2018
jasnell
approved these changes
May 3, 2018
shigeki
approved these changes
May 4, 2018
addaleax
commented
May 6, 2018
Member
Landed in a1f342f 🎉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #20501
Refs: #20385