Uh oh!
There was an error while loading. Please reload this page.
src: minor refactor to string_search.h - #20546
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
- Use `std::max` instead of a custom variant - Use member method pointers to avoid an extra layer of indirection - Stop transferring `Vector` into the `node` namespace
addaleax
commented
May 5, 2018
MemberAuthor
addaleax
commented
May 5, 2018
MemberAuthor
FreeBSD re-run: https://ci.nodejs.org/job/node-test-commit-freebsd/17534/ |
jasnell
approved these changes
May 6, 2018
danbev
approved these changes
May 7, 2018
TimothyGu
approved these changes
May 7, 2018
addaleax
commented
May 9, 2018
MemberAuthor
Landed in 9873875 |
addaleax added a commit
that referenced
this pull request
May 9, 2018
- Use `std::max` instead of a custom variant - Use member method pointers to avoid an extra layer of indirection - Stop transferring `Vector` into the `node` namespace PR-URL: #20546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos pushed a commit
that referenced
this pull request
May 12, 2018
- Use `std::max` instead of a custom variant - Use member method pointers to avoid an extra layer of indirection - Stop transferring `Vector` into the `node` namespace PR-URL: #20546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::maxinstead of a custom variantVectorinto thenodenamespaceChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes