Uh oh!
There was an error while loading. Please reload this page.
doc, tools: unify stability signatures - #20552
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
vsemozhetbyt
commented
May 6, 2018
ContributorAuthor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
commented
May 6, 2018
ContributorAuthor
jasnell
approved these changes
May 6, 2018
trivikr
approved these changes
May 6, 2018
trivikr
left a comment
Member
There was a problem hiding this comment.
Verified the final output in private branch
lpinca
approved these changes
May 7, 2018
vsemozhetbyt
commented
May 8, 2018
ContributorAuthor
Landed in 5f2b67d |
vsemozhetbyt added a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2 tasks
targos pushed a commit
that referenced
this pull request
May 12, 2018
PR-URL: #20552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesCurrently, we format all stability signatures in blockquotes except just this place in
documentation.md, where they are wrapped in code elements. I can assume that the cause is that markdown glues consecutive blockquotes into one element, which seems wrong for this fragment.However, this divergence makes our MD-2-HTML converter check all the code elements for stability signatures, which is rather a significant overhead.
So this PR unifies stability signatures (separating consecutive blockquotes by comments) and frees the converter from the excess checks.
The visible result is completely identical to the previous one.