Skip to content

v8: backport 9fb02b526f1cd3b859a530a01adb08bc0d089f4f - #20575

Closed
devsnek wants to merge 1 commit into
nodejs:masterfrom
devsnek:backport/v8-9fb02b526f1cd3b859a530a01adb08bc0d089f4f
Closed

v8: backport 9fb02b526f1cd3b859a530a01adb08bc0d089f4f#20575
devsnek wants to merge 1 commit into
nodejs:masterfrom
devsnek:backport/v8-9fb02b526f1cd3b859a530a01adb08bc0d089f4f

Conversation

@devsnek

Copy link
Copy Markdown
Member

Refs: v8/v8@9fb02b5

Original commit message:

Allow function callbacks to have Proxy as receiver.
R=verwaest@chromium.org
Bug: v8:5773
Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b
Reviewed-on: chromium-review.googlesource.com/1046088
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53015}
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refs: v8/v8@9fb02b5
Original commit message:
Allow function callbacks to have Proxy as receiver.
R=verwaest@chromium.org
Bug: v8:5773
Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b
Reviewed-on: chromium-review.googlesource.com/1046088
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#53015}
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels May 7, 2018
@devsnekdevsnek removed the build Issues and PRs related to build files or the CI. label May 7, 2018
@devsnek

Copy link
Copy Markdown
MemberAuthor

@devsnekdevsnek added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2018
@devsnek

Copy link
Copy Markdown
MemberAuthor

landed in 5db018d

@devsnekdevsnek closed this May 9, 2018
@devsnekdevsnek removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2018
@devsnek
devsnek deleted the backport/v8-9fb02b526f1cd3b859a530a01adb08bc0d089f4f branch May 9, 2018 14:08
devsnek added a commit that referenced this pull request May 9, 2018
Refs: v8/v8@9fb02b5
Original commit message:
Allow function callbacks to have Proxy as receiver.
R=verwaest@chromium.org
Bug: v8:5773
Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b
Reviewed-on: chromium-review.googlesource.com/1046088
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53015}
PR-URL: #20575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@TimothyGu

Copy link
Copy Markdown
Member

For future commits to V8, it would be great if we could cut down the commit hash in the commit message a bit. Also the subsystem is in fact deps.

@targos

Copy link
Copy Markdown
Member

The git node v8 command can help with that. In this case, it would have generated:

 deps: cherry-pick 9fb02b5 from upstream V8
Original commit message:
Allow function callbacks to have Proxy as receiver.
R=verwaest@chromium.org
Bug: v8:5773
Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b
Reviewed-on: https://chromium-review.googlesource.com/1046088
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53015}
Refs: https://github.com/v8/v8/commit/9fb02b526f1cd3b859a530a01adb08bc0d089f4f

By the way, we usually say cherry-pick when the change applies cleanly and backport when conflicts have to be resolved manually.

targos pushed a commit that referenced this pull request May 12, 2018
Refs: v8/v8@9fb02b5
Original commit message:
Allow function callbacks to have Proxy as receiver.
R=verwaest@chromium.org
Bug: v8:5773
Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b
Reviewed-on: chromium-review.googlesource.com/1046088
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53015}
PR-URL: #20575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@addaleaxaddaleax mentioned this pull request May 14, 2018
targos pushed a commit to targos/node that referenced this pull request May 31, 2018
Refs: v8/v8@9fb02b5
Original commit message:
Allow function callbacks to have Proxy as receiver.
R=verwaest@chromium.org
Bug: v8:5773
Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b
Reviewed-on: chromium-review.googlesource.com/1046088
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#53015}
PR-URL: nodejs#20575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2018
Refs: v8/v8@9fb02b5
Original commit message:
Allow function callbacks to have Proxy as receiver.
R=verwaest@chromium.org
Bug: v8:5773
Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b
Reviewed-on: chromium-review.googlesource.com/1046088
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53015}
PR-URL: #20575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2018
Refs: v8/v8@9fb02b5
Original commit message:
Allow function callbacks to have Proxy as receiver.
R=verwaest@chromium.org
Bug: v8:5773
Change-Id: Ifd29a1116ee8c86b8d8d24485bbfd19e260ab66b
Reviewed-on: chromium-review.googlesource.com/1046088
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53015}
PR-URL: #20575
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorinsMylesBorins mentioned this pull request Jun 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@devsnek@TimothyGu@targos@bnoordhuis@jasnell@nodejs-github-bot