Uh oh!
There was an error while loading. Please reload this page.
tools: add v10 to alternative version docs menu - #20586
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
vsemozhetbyt
commented
May 7, 2018
ContributorAuthor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
commented
May 7, 2018
ContributorAuthor
vsemozhetbyt
commented
May 7, 2018
ContributorAuthor
@nodejs/release, maybe this is worth to be added to a release TODO list if we have one) |
cjihrig
approved these changes
May 7, 2018
devsnek
approved these changes
May 7, 2018
trivikr
approved these changes
May 8, 2018
lpinca
approved these changes
May 8, 2018
vsemozhetbyt
commented
May 8, 2018
ContributorAuthor
Landed in 802a631 |
vsemozhetbyt added a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20586 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20586 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20586 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2 tasks
MylesBorins pushed a commit
that referenced
this pull request
May 9, 2018
PR-URL: #20586 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesBefore:
After: