Uh oh!
There was an error while loading. Please reload this page.
lib: return directly from packageMainCache - #20591
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit updates readPackage to return directly when calling packageMainCache instead of storing the result in a local var and returning later.
danbev
commented
May 8, 2018
ContributorAuthor
targos
approved these changes
May 8, 2018
targos
approved these changes
May 8, 2018
devsnek
approved these changes
May 8, 2018
trivikr
approved these changes
May 8, 2018
cjihrig
approved these changes
May 8, 2018
BridgeAR
approved these changes
May 8, 2018
jasnell
approved these changes
May 8, 2018
tniessen
approved these changes
May 9, 2018
danbev
commented
May 10, 2018
ContributorAuthor
Landed in 6446510. |
danbev added a commit
that referenced
this pull request
May 10, 2018
This commit updates readPackage to return directly when calling packageMainCache instead of storing the result in a local var and returning later. PR-URL: #20591 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit
that referenced
this pull request
May 12, 2018
This commit updates readPackage to return directly when calling packageMainCache instead of storing the result in a local var and returning later. PR-URL: #20591 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates readPackage to return directly when calling
packageMainCache instead of storing the result in a local var
and returning later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes