Skip to content

vm: move emitExperimentalWarning - #20593

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:vm_module_move_emitExperimentalWarning
Closed

vm: move emitExperimentalWarning#20593
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:vm_module_move_emitExperimentalWarning

Conversation

@danbev

@danbevdanbev commented May 8, 2018

Copy link
Copy Markdown
Contributor

This commit moves emitExperimentalWarning into the second object
destructoring of require internal/util.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
vm: move emitExperimentalWarning
b671fa6
This commit moves emitExperimentalWarning into the second object
destructoring of require internal/util.
@nodejs-github-botnodejs-github-bot added the vm Issues and PRs related to the vm subsystem. label May 8, 2018
@danbev

danbev commented May 8, 2018

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/14713/

@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 8, 2018
@addaleax

addaleax commented May 9, 2018

Copy link
Copy Markdown
Member

Landed in facb2c5

@addaleaxaddaleax closed this May 9, 2018
addaleax pushed a commit that referenced this pull request May 9, 2018
@danbev@addaleax
vm: move emitExperimentalWarning
facb2c5
This commit moves emitExperimentalWarning into the second object
destructoring of require internal/util.
PR-URL: #20593
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request May 12, 2018
@danbev@targos
vm: move emitExperimentalWarning
8604481
This commit moves emitExperimentalWarning into the second object
destructoring of require internal/util.
PR-URL: #20593
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleaxaddaleax mentioned this pull request May 14, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+3 more reviewers
@TimothyGuTimothyGuTimothyGu approved these changes
@maclover7maclover7maclover7 approved these changes
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@danbev@addaleax@ChALkeR@jasnell@TimothyGu@targos@cjihrig@maclover7@devsnek@BridgeAR@nodejs-github-bot