Uh oh!
There was an error while loading. Please reload this page.
doc: update VM section text - #20595
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit updates the VM section with suggestion for a minor improvement (hopefully) of the text.
danbev
commented
May 8, 2018
ContributorAuthor
vsemozhetbyt
approved these changes
May 8, 2018
vsemozhetbyt
commented
May 8, 2018
Contributor
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
devsnek
approved these changes
May 8, 2018
jasnell
approved these changes
May 8, 2018
Trott
approved these changes
May 8, 2018
lpinca
approved these changes
May 8, 2018
danbev
commented
May 9, 2018
ContributorAuthor
Landed in 5c9572d. |
danbev added a commit
to danbev/node
that referenced
this pull request
May 9, 2018
This commit updates the VM section with suggestion for a minor improvement (hopefully) of the text. PR-URL: nodejs#20595 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
May 12, 2018
This commit updates the VM section with suggestion for a minor improvement (hopefully) of the text. PR-URL: #20595 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the VM section with suggestion for a minor
improvement (hopefully) of the text.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes