Uh oh!
There was an error while loading. Please reload this page.
test: apply test-fs-access to promises API - #20667
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Add tests for `fs.promises.access()` in all test cases in `test-fs-access` that are relevant to the Promises-based API.
Trott
commented
May 11, 2018
MemberAuthor
Trott
commented
May 11, 2018
MemberAuthor
For clarity, suppress whitespace changes in the diff: https://github.com/nodejs/node/pull/20667/files?utf8=%E2%9C%93&diff=unified&w=1 |
danbev
approved these changes
May 11, 2018
Trott
commented
May 12, 2018
MemberAuthor
Linux re-run: https://ci.nodejs.org/job/node-test-commit-linux/18682/ |
Trott
commented
May 12, 2018
MemberAuthor
@nodejs/fs @ChALkeR |
Trott
commented
May 12, 2018
MemberAuthor
@nodejs/testing |
Trott
commented
May 14, 2018
MemberAuthor
While this can land as things stand now, I'd love to get another review or two. @nodejs/collaborators |
benjamingr
approved these changes
May 14, 2018
addaleax
commented
May 14, 2018
Member
Landed in 617f0d2 |
addaleax pushed a commit
that referenced
this pull request
May 14, 2018
Add tests for `fs.promises.access()` in all test cases in `test-fs-access` that are relevant to the Promises-based API. PR-URL: #20667 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax pushed a commit
that referenced
this pull request
May 14, 2018
Add tests for `fs.promises.access()` in all test cases in `test-fs-access` that are relevant to the Promises-based API. PR-URL: #20667 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This was referenced May 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for
fs.promises.access()in all test cases intest-fs-accessthat are relevant to the Promises-based API.In the course of working on #20439, I started to wonder if adding more abstractions in the test suite was a mistake. This is what things look like fixing up one of the many
fstests to also test the promises-based API. I suspect the end result is easier to follow and easier to emulate in other tests.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes