Uh oh!
There was an error while loading. Please reload this page.
src: use unqualified names in node_contextify.cc - #20669
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit removes the usage of qualified names for consistency.
danbev
commented
May 11, 2018
ContributorAuthor
targos
approved these changes
May 11, 2018
addaleax
approved these changes
May 11, 2018
TimothyGu
approved these changes
May 11, 2018
cjihrig
approved these changes
May 11, 2018
tniessen
approved these changes
May 11, 2018
lpinca
approved these changes
May 11, 2018
jasnell
approved these changes
May 12, 2018
danbev
commented
May 13, 2018
ContributorAuthor
node-teset-commit-arm-fanned failure looks unrelated02:51:11 not ok 1 async-hooks/test-callback-error02:51:11 ---02:51:11 duration_ms: 23.17602:51:11 severity: fail02:51:11 exitcode: 102:51:11 stack: |-02:51:11 start case 102:51:11 end case 1: 2739.156ms02:51:11 start case 202:51:11 end case 2: 2560.894ms02:51:11 start case 302:51:11 end case 3: 200.600ms02:51:11 Error: test_callback_abort02:51:11 at ActivityCollector.initHooks.oninit.common.mustCall (/home/iojs/build/workspace/node-test-binary-arm/test/async-hooks/test-callback-error.js:27:45)02:51:11 at ActivityCollector.oninit (/home/iojs/build/workspace/node-test-binary-arm/test/common/index.js:474:15)02:51:11 at ActivityCollector._init (/home/iojs/build/workspace/node-test-binary-arm/test/async-hooks/init-hooks.js:185:10)02:51:11 at emitInitNative (internal/async_hooks.js:137:43)02:51:11 at emitInitScript (internal/async_hooks.js:336:3)02:51:11 at new AsyncResource (async_hooks.js:164:5)02:51:11 at Object.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/async-hooks/test-callback-error.js:29:5)02:51:11 at Module._compile (internal/modules/cjs/loader.js:677:30)02:51:11 at Object.Module._extensions..js (internal/modules/cjs/loader.js:688:10)02:51:11 at Module.load (internal/modules/cjs/loader.js:588:32)02:51:11 02:51:11 ... |
danbev
commented
May 13, 2018
ContributorAuthor
Landed in f9c6fd0. |
danbev added a commit
that referenced
this pull request
May 13, 2018
This commit removes the usage of qualified names for consistency. PR-URL: #20669 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
May 14, 2018
This commit removes the usage of qualified names for consistency. PR-URL: #20669 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the usage of qualified names for consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes