Skip to content

src: remove unused includes from node_contextify.h - #20670

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:contextify_remove_unused_includes
Closed

src: remove unused includes from node_contextify.h#20670
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:contextify_remove_unused_includes

Conversation

@danbev

@danbevdanbev commented May 11, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels May 11, 2018
@danbev

danbev commented May 11, 2018

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/14807/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2018
@danbev

danbev commented May 13, 2018

Copy link
Copy Markdown
ContributorAuthor

Landed in a9b399f.

@danbevdanbev closed this May 13, 2018
@danbev
danbev deleted the contextify_remove_unused_includes branch May 13, 2018 15:11
danbev added a commit that referenced this pull request May 13, 2018
@danbev
src: remove unused includes from node_contextify.h
a9b399f
PR-URL: #20670
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request May 14, 2018
@danbev@addaleax
src: remove unused includes from node_contextify.h
9422909
PR-URL: #20670
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleaxaddaleax mentioned this pull request May 14, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@danbev@jasnell@addaleax@lpinca@TimothyGu@targos@cjihrig@nodejs-github-bot