console: .table fall back to logging for function too

[ohbarye]

Hello @devsnek
I prepared a pull request for #20679.

---

Overview

According to the console.table document, it reads that it "falls back to just logging the argument if it can’t be parsed as tabular."

But it doesn't fall back when I give a function as its first argument. It logs an empty table.

Fixes: #20679

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• [ ] documentation is changed or added (I think it's not necessary this time)
• commit message follows commit guidelines

[vsemozhetbyt]

CI: https://ci.nodejs.org/job/node-test-pull-request/14816/

[Trott]

This will break current behavior in the situation where a function has properties attached to it:

$ ./node
> foo = function() {}[Function: foo]
> foo.bar = 'hey''hey'
> console.table(foo)┌─────────┬────────┐│ (index) │ Values │├─────────┼────────┤│ bar │ 'hey' │└─────────┴────────┘undefined
>

Honest question: Do we care?

In both situations, Chrome appears to publish a blank line. Firefox, in contrast, does what this PR does.

FWIW, my interpretation of the spec is that our current behavior is correct.

[devsnek]

i'm fine with this change. if you want to get really into it you could check the getOwnPropertyNames and filter out 'length', 'name', 'arguments', 'caller', 'prototype' and if it still has anything left then display it as tabular data. (but i don't think thats a needed feature)

[Trott]

Thinking more about this, yeah, I don't object to this change. It's not my preference, but I can certainly see it this way, and we can always revisit if the spec ever gets more specific about how to handle functions.

[BridgeAR]

Landed in 0c852a1

@ohbarye congratulations on your first commit to Node.js! 🎉 You are now officially a contributor :-)

[ohbarye]

Thank you for your review and the warm welcome! :)