Uh oh!
There was an error while loading. Please reload this page.
test: fix flaky test-http2-session-timeout - #20692
Conversation
Trott
commented
May 13, 2018
This version of the test is demonstrably more reliable than the current version when tested this way:
You may need to adjust the value of the Current version of test: 142/50, 159/33, 153/39 /cc @apapirovski |
Trott
commented
May 13, 2018
There was a problem hiding this comment.
I'm -1 on this change. process.hrtime isn't cheap so it's more — not less — likely to create situations where this test fails on slow platforms.
Actually, scratch that, I see what's making this more reliable.
There was a problem hiding this comment.
Nit: if I'm not wrong we can pass makeReq directly without wrapping it in another function.
richardlau
commented
May 14, 2018
#20692 (comment) suggests this doesn't fix the test but instead makes it less likely to fail, i.e., it's still flaky? If so can we reword the commit to something other than |
Check actual expired time rather than relying on a number of calls to setTimeout() in test-http2-session-timeout more robust. Fixes: nodejs#20628
Trott
commented
May 14, 2018
@richardlau I went with "improve reliability" although I had to abbreviate the test name to keep it under 50 chars. (I removed |
Trott
commented
May 15, 2018
apapirovski
commented
May 16, 2018
Landed in 9e4ae56 |
Check actual expired time rather than relying on a number of calls to setTimeout() in test-http2-session-timeout more robust. PR-URL: #20692Fixes: #20628 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Check actual expired time rather than relying on a number of calls to setTimeout() in test-http2-session-timeout more robust. PR-URL: #20692Fixes: #20628 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Check actual expired time rather than relying on a number of calls to setTimeout() in test-http2-session-timeout more robust. PR-URL: nodejs#20692Fixes: nodejs#20628 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Check actual expired time rather than relying on a number of calls to setTimeout() in test-http2-session-timeout more robust. PR-URL: nodejs#20692Fixes: nodejs#20628 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Check actual expired time rather than relying on a number of calls to setTimeout() in test-http2-session-timeout more robust. PR-URL: nodejs#20692Fixes: nodejs#20628 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Check actual expired time rather than relying on a number of calls to setTimeout() in test-http2-session-timeout more robust. Backport-PR-URL: #22850 PR-URL: #20692Fixes: #20628 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Check actual expired time rather than relying on a number of calls to
setTimeout()in test-http2-session-timeout more robust.Fixes: #20628
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes