Skip to content

doc: fix typo in dns docs - #20711

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:dns-typo
Closed

doc: fix typo in dns docs#20711
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:dns-typo

Conversation

@addaleax

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels May 14, 2018
@tniessen

Copy link
Copy Markdown
Member

Collaborators, 👍 here if you approve fast-tracking.

@tniessentniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2018
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2018
@tniessen

Copy link
Copy Markdown
Member

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax

Copy link
Copy Markdown
MemberAuthor

Landed in 64b5046

@addaleax
addaleax deleted the dns-typo branch May 14, 2018 16:07
addaleax added a commit that referenced this pull request May 14, 2018
PR-URL: #20711
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit that referenced this pull request May 14, 2018
PR-URL: #20711
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@addaleaxaddaleax mentioned this pull request May 14, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dnsIssues and PRs related to the dns subsystem.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@addaleax@tniessen@danbev@XadillaX@hiroppy@BridgeAR@mhdawson@trivikr@nodejs-github-bot