Uh oh!
There was an error while loading. Please reload this page.
doc: fix typo the the - #20716
Closed
shisama wants to merge 2 commits into
Closed
Conversation
trivikr
requested changes
May 14, 2018
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Member
There was a problem hiding this comment.
This should not be fixed. The commit message itself is wrong and therefore it should stay the way it is.
Fix typo `the the`. Fixes: nodejs#20682
BridgeAR
approved these changes
May 14, 2018
BridgeAR
left a comment
Member
There was a problem hiding this comment.
LGTM with my comment addressed.
Member
There was a problem hiding this comment.
This should not be fixed. The commit message itself is wrong and therefore it should stay the way it is.
trivikr
approved these changes
May 14, 2018
revert CHANGELOG_V8.md to ffb503b because the commit message itself is wrong.
shisama
commented
May 14, 2018
ContributorAuthor
@BridgeAR |
trivikr
approved these changes
May 14, 2018
cjihrig
approved these changes
May 14, 2018
lpinca
approved these changes
May 14, 2018
jasnell
approved these changes
May 15, 2018
apapirovski
commented
May 16, 2018
Contributor
apapirovski
commented
May 16, 2018
Contributor
apapirovski pushed a commit
that referenced
this pull request
May 16, 2018
PR-URL: #20716Fixes: #20682 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #20716Fixes: #20682 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
PR-URL: nodejs/node#20716Fixes: nodejs/node#20682 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
PR-URL: nodejs/node#20716Fixes: nodejs/node#20682 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BaochengSu pushed a commit
to BaochengSu/node
that referenced
this pull request
Oct 20, 2020
PR-URL: nodejs#20716Fixes: nodejs#20682 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit 3b1bf0d)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo
the the.Fixes: #20682
Checklist