Skip to content

test: slightly improve test-util-inspect assertions - #20721

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:test-util-inspect-weakmap-error
Closed

test: slightly improve test-util-inspect assertions#20721
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:test-util-inspect-weakmap-error

Conversation

@addaleax

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label May 14, 2018
@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2018
@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 15, 2018
@apapirovski

Copy link
Copy Markdown
Contributor

@apapirovski

Copy link
Copy Markdown
Contributor

Landed in daa5921

apapirovski pushed a commit that referenced this pull request May 16, 2018
PR-URL: #20721
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
PR-URL: #20721
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleaxaddaleax mentioned this pull request May 22, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@addaleax@apapirovski@danbev@jasnell@Trott@lpinca@cjihrig@hiroppy@BridgeAR@trivikr@nodejs-github-bot