Skip to content

doc: add missing changes: entry for assert.throws - #20723

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:assert-throws-changes
Closed

doc: add missing changes: entry for assert.throws#20723
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:assert-throws-changes

Conversation

@addaleax

@addaleaxaddaleax commented May 14, 2018

Copy link
Copy Markdown
Member

Refs: #20485

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels May 14, 2018
@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2018
@addaleax

addaleax commented May 14, 2018

Copy link
Copy Markdown
MemberAuthor

/cc @BridgeAR

Please 👍 to approve fast-tracking this.

CI: https://ci.nodejs.org/job/node-test-commit-lite/885/

ryzokuken
ryzokuken approved these changes May 14, 2018
View reviewed changes

@ryzokukenryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@addaleax

addaleax commented May 14, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 50b334b

addaleax added a commit that referenced this pull request May 14, 2018
@addaleax
doc: add missing changes: entry for assert.throws
50b334b
Refs: #20485
PR-URL: #20723
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@addaleax
addaleax deleted the assert-throws-changes branch May 14, 2018 18:00
addaleax added a commit that referenced this pull request May 14, 2018
@addaleax
doc: add missing changes: entry for assert.throws
9ecc746
Refs: #20485
PR-URL: #20723
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@addaleaxaddaleax mentioned this pull request May 14, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@addaleax@MylesBorins
doc: add missing changes: entry for assert.throws
fd14ec1
Refs: #20485
PR-URL: #20723
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@ryzokukenryzokukenryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@addaleax@BridgeAR@ryzokuken@nodejs-github-bot