doc: fix typo in COLLABORATOR_GUIDE.md

[vsemozhetbyt]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

Refs: #20740

[vsemozhetbyt]

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/710/

[vsemozhetbyt]

cc @nodejs/linting How can we fix the linting issue in this case?

[BridgeAR]

@vsemozhetbyt good question... I guess it would actually be best to rename the group instead.

Ping @nodejs/tsc

[ofrobots]

{digression} IMHO, this doesn't need review from the TSC or even a ping to the list of all collaborators – this is an uncontroversial typo fix. Global pings should be avoided unless necessary. {/digression}

[mhdawson]

LGTM

[Trott]

How about we change the capitalization on the group name instead (and in the CODEOWNERS file too)? Then the linter will be happy and we'll have a group name that correctly styles the name V8. We've tried to use V8 everywhere to avoid confusion about v being for version and also just to be consistent with Google's styling for the JavaScript engine.

[Trott]

(@ofrobots I think the ping may have been automated by the CODEOWNERS file. It's possible we don't need a TSC ping for changes to COLLABORATOR_GUIDE. Basically only if it entails a governance change. Maybe that line can be removed from CODEOWNERS.)

[Trott]

I'd prefer we change the name of the team to use V8.

[vsemozhetbyt]

@ofrobots It seems the ping was not about typo itself: we have a conflict between linting rule requiring V8 case and the team name with v8. If we land it this way, we will have constant linting failures. If we leave it out, we will have broken team tag.

[Trott]

@vsemozhetbyt Are you 👍if I change the team name to use V8 instead of v8? Then we can close this PR and you (or I or anyone else) can update the CODEOWNERS file?

[vsemozhetbyt]

@Trott Yes, please, this seems more consistent.

[Trott]

It appears that GitHub has started (or maybe always has?) lowercasing team names in @-mentions regardless of how you actually name the team.

I'll see about updating the prohibited-strings code to ignore prohibited strings that appear inside of @-strings so this starts passing.

[Trott]

Published a new version of remark-lint-prohibited-strings to avoid the false positive here. Unfortunately, people will likely need to do make lint-md-clean && make lint-md-build after this lands to avoid getting the lint error.

I put the update as the first commit on this PR with the original changes as the second commit. (I recommend leaving them separate for what I hope are obvious reasons.)

Full CI (because now we're updating tools): https://ci.nodejs.org/job/node-test-pull-request/14895/

@vsemozhetbyt Thanks for your patience with this!

[Trott]

Hmmm...looks like I need to remove some OS-dependent stuff:

17:41:03 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):17:41:03 npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"freebsd","arch":"x64"})

[Trott]

CI: https://ci.nodejs.org/job/node-test-commit/18517/

[Trott]

Re-running arm-fanned, addons failure is clearly spurious: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1230/

[Trott]

Got better results this time, but still some spurious ones in arm-fanned. Trying that one again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1231/

[Trott]

I'm wondering if all my terminating of Pi jobs in process is what's causing the problem for arm-fanned. Going to let the last one finish this time. Again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1232/

[Trott]

(Other than arm-fanned, CI is totally green.)

[Trott]

arm-fanned is green too now. Landing...

[Trott]

Oops, not landing because it hasn't been approved for fast-tracking.

[vsemozhetbyt]

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

[devsnek]

the first commit only modifies two package-lock.json files?

[devsnek]

@Trott is there not also a package.json to update?

[Trott]

@Trott is there not also a package.json to update?

It's not necessary, but there could be one. That would require publishing a new version of remark-preset-lint-node to change ^1.0.0 to ^1.0.3 in one line of the relevant package.json. Didn't seem worth it since npm install will grab 1.0.3 anyway. But, if you want, I'll totally do it if there might be something I'm missing or even if just for aesthetic reasons.

[devsnek]

@Trott if it isn't needed its fine, i was just confused when i saw lock files changed without the actual package changing is all

[vsemozhetbyt]

@Trott Are we good to land?

[BridgeAR]

Landed in 40469b4, 59f71ea 🎉

[Trott]

@Trott Are we good to land?

@vsemozhetbyt A belated "yes". :-D