Uh oh!
There was an error while loading. Please reload this page.
fs: fix and cleanup constants - #20765
Closed
jasnell wants to merge 4 commits into
Closed
Conversation
These were missed during the initial review
jasnell
commented
May 16, 2018
MemberAuthor
jasnell
commented
May 16, 2018
MemberAuthor
/cc @nodejs/fs |
targos
approved these changes
May 16, 2018
danbev
approved these changes
May 16, 2018
joyeecheung
approved these changes
May 16, 2018
joyeecheung
commented
May 16, 2018
Member
Please thumbs up this reply if you are +1 to fast-track. |
cjihrig
approved these changes
May 16, 2018
ronkorving
approved these changes
May 17, 2018
lpinca
approved these changes
May 17, 2018
BridgeAR
approved these changes
May 18, 2018
jasnell added a commit
that referenced
this pull request
May 18, 2018
* only require('buffer') once
* use constants directly
* fix incorrect constants
PR-URL: #20765
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>jasnell
commented
May 18, 2018
MemberAuthor
Landed in 1d3759a |
MylesBorins pushed a commit
that referenced
this pull request
May 22, 2018
* only require('buffer') once
* use constants directly
* fix incorrect constants
PR-URL: #20765
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subset of commits that were originally in #20734
Cleans up some constants usage in
fsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes