Uh oh!
There was an error while loading. Please reload this page.
util: improve inspect - #20802
Closed
BridgeAR wants to merge 4 commits into
Closed
Conversation
BridgeAR
commented
May 17, 2018
MemberAuthor
jasnell
approved these changes
May 17, 2018
Trott
commented
May 19, 2018
Member
Would be curious to see CITGM results as I could see this impacting test suites. (But maybe not?) |
trivikr
approved these changes
May 20, 2018
BridgeAR
commented
May 20, 2018
MemberAuthor
@addaleax about this being semver-major: we actually have the following in our docs: So I personally do not think this is semver-major. When added, it was somewhat meant for changes like these as far as I can tell. |
addaleax
commented
May 20, 2018
Member
@BridgeAR Yes, this is definitely in the “erring on the side of caution” category. I know that people shouldn’t depend on it, but I’m not sure this change is trivial enough to have a reasonable expectation that it doesn’t break people’s code. If there is a good reason for this not being semver-major (as in, a significant advantage for us), we can remove the label. CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1418/ |
This aligns the visualization of an error with no stack traces set to zero just as it is done in case the error has no stack trace.
When inspecting nested objects some times a whitespace was added at the end of a line. This fixes this erroneous space. Besides that the `breakLength` was not followed if a single property was longer than the breakLength. It will now break a single property into the key and value in such cases.
Error stacks and multiline error messages were not correct indented. This is fixed by this patch.
When inspecting errors with extra properties while setting the
compact option to false, it will now return:
[Error: foo] {
at repl:1:5
at Script.runInThisContext (vm.js:89:20)
bla: true
}
Instead of:
Error: foo
at repl:1:5
at Script.runInThisContext (vm.js:91:20) {
bla: true
}BridgeARforce-pushed
the
improve-error-inspection
branch
from
May 20, 2018 20:27
04c0c48 to
9c1d559CompareBridgeAR
commented
May 20, 2018
MemberAuthor
Rebased due to conflicts. New CI https://ci.nodejs.org/job/node-test-pull-request/14988/ Since the conflicts required some more work, PTAL. @addaleax one main benefit would be easier backports. |
BridgeAR
commented
May 21, 2018
MemberAuthor
As a note: nothing seem to show up on CITGM. |
mcollina
commented
May 21, 2018
Member
Still LGTM |
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
May 21, 2018
This aligns the visualization of an error with no stack traces set to zero just as it is done in case the error has no stack trace. PR-URL: nodejs#20802 Refs: nodejs#20253 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
May 21, 2018
When inspecting nested objects some times a whitespace was added at the end of a line. This fixes this erroneous space. Besides that the `breakLength` was not followed if a single property was longer than the breakLength. It will now break a single property into the key and value in such cases. PR-URL: nodejs#20802 Refs: nodejs#20253 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
May 21, 2018
Error stacks and multiline error messages were not correct indented. This is fixed by this patch. PR-URL: nodejs#20802 Refs: nodejs#20253 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
May 21, 2018
When inspecting errors with extra properties while setting the
compact option to false, it will now return:
[Error: foo] {
at repl:1:5
at Script.runInThisContext (vm.js:89:20)
bla: true
}
Instead of:
Error: foo
at repl:1:5
at Script.runInThisContext (vm.js:91:20) {
bla: true
}
PR-URL: nodejs#20802
Refs: nodejs#20253
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>BridgeAR
commented
May 21, 2018
MemberAuthor
Thanks. Landed in 7f0f978...c041a2e 🎉 |
BridgeAR
commented
May 21, 2018
MemberAuthor
@addaleax I still think it would be best not to have this as semver-major. |
addaleax
commented
May 21, 2018
Member
@BridgeAR If you feel strongly about this, you can remove the label… I don’t think this is something we’d want to backport to an LTS line, though |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check the commit messages for the details.
Refs: #20253
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes