Skip to content

doc: fix fs.promises sample codes. - #20805

Closed
kakts wants to merge 2 commits into
nodejs:masterfrom
kakts:fix-fs-promises
Closed

doc: fix fs.promises sample codes.#20805
kakts wants to merge 2 commits into
nodejs:masterfrom
kakts:fix-fs-promises

Conversation

@kakts

Copy link
Copy Markdown
Contributor

Summary

Fix fs.promises sample codes in doc/api/fs.md .

Please review this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 17, 2018
@benjamingr

Copy link
Copy Markdown
Member

Thanks, I'm +1 on the change though note that #20559 is landing soon

# Conflicts:
#	doc/api/fs.md
@kakts

Copy link
Copy Markdown
ContributorAuthor

I'll close this PR and recreate.

@kaktskakts closed this May 19, 2018
@kaktskakts mentioned this pull request May 19, 2018
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kakts@benjamingr@nodejs-github-bot