Uh oh!
There was an error while loading. Please reload this page.
Revert "doc: fix typo in COLLABORATOR_GUIDE.md" - #20829
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
This reverts commit 59f71ea. Quick fix for the following linter error: ``` COLLABORATOR_GUIDE.md 846:46-846:66 warning Use "V8" instead of "v8" prohibited-strings remark-lint ⚠ 1 warning ``` (Despite being a warning, this breaks `make test`, and I don’t know how else to address it.)
addaleax
commented
May 18, 2018
MemberAuthor
CI lite: https://ci.nodejs.org/job/node-test-pull-request-lite/728/ Please 👍 this comment to approve fast-tracking. |
addaleax
commented
May 18, 2018
MemberAuthor
The single LinuxOne test failure is definitely unrelated to this one-liner, and I’ve seen it in other CI runs today so far too. |
addaleax
commented
May 18, 2018
MemberAuthor
Okay, figured out thanks to @BridgeAR how to address this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 59f71ea.
Quick fix for the following linter error:
(Despite being a warning, this breaks
make test,and I don’t know how else to address it.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes