Uh oh!
There was an error while loading. Please reload this page.
test: mark tests as flaky as intermediate step - #20835
Closed
BridgeAR wants to merge 2 commits into
Closed
Conversation
BridgeAR
commented
May 19, 2018
MemberAuthor
We have a few http2 issues that are currently resolved. Until they are, just mark these two tests as flaky.
3 tasks
addaleax
commented
May 19, 2018
Member
BridgeAR
commented
May 19, 2018
MemberAuthor
@addaleax this way the test itself does not have to be touched though and the code can be fixed. I personally believe that the status is somewhat meant for cases like the current one where in case we do not want a full revert. |
apapirovski
commented
May 19, 2018
Contributor
I prefer this since the tests will still fail instead of just being green but won't make the CI red. |
4 tasks
gireeshpunathil
commented
May 19, 2018
Member
frequent CI failures due to flaky tests have been an issue off late - causes confusion to the PR at hand, needing to re-run leading to additional time and effort. Marking flaky until they are fixed is a good idea. |
gireeshpunathil
approved these changes
May 19, 2018
BridgeAR
commented
May 19, 2018
MemberAuthor
addaleax
commented
May 19, 2018
Member
@BridgeAR Feel free to land it, yes |
BridgeAR
commented
May 19, 2018
MemberAuthor
Landed in 8254e38 |
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
May 19, 2018
We have a few http2 issues that are currently resolved. Until they are, just mark these two tests as flaky. PR-URL: nodejs#20835 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
May 22, 2018
We have a few http2 issues that are currently resolved. Until they are, just mark these two tests as flaky. PR-URL: #20835 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a few http2 issues that are currently resolved. Until they
are just mark these two tests as flaky.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes