Skip to content

cli: add --prof flag description to node --help command - #20845

Closed
ohbarye wants to merge 2 commits into
nodejs:masterfrom
ohbarye:add-prof-to-help-command
Closed

cli: add --prof flag description to node --help command#20845
ohbarye wants to merge 2 commits into
nodejs:masterfrom
ohbarye:add-prof-to-help-command

Conversation

@ohbarye

@ohbaryeohbarye commented May 20, 2018

Copy link
Copy Markdown
Contributor

As suggested at #16459 (comment), I added description about --flag option into node --help command.

Closes: #16459

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included I think it's necessary for this change
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 20, 2018
ohbarye
ohbarye commented May 20, 2018
View reviewed changes
Comment threaddoc/api/cli.md Outdated

@ohbaryeohbaryeMay 20, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct...? 🤔

@targostargosMay 20, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the version it was introduced in, but it is much older than that. The flag already exists in 0.10.

@BridgeARBridgeARMay 20, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked and the log file is generated from v.2.0.0 on.

vsemozhetbyt
vsemozhetbyt reviewed May 20, 2018
View reviewed changes
Comment threaddoc/api/cli.md Outdated

@vsemozhetbytvsemozhetbytMay 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: v8 -> V8.

Comment threaddoc/node.1 Outdated

@vsemozhetbytvsemozhetbytMay 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto)

Comment threadsrc/node.cc Outdated

@vsemozhetbytvsemozhetbytMay 20, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. And maybe you can fix the same typo on the next line?

@vsemozhetbytvsemozhetbyt added doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency. performance Issues and PRs related to the performance of Node.js. labels May 20, 2018
@ohbarye
ohbaryeforce-pushed the add-prof-to-help-command branch from 127aad4 to e3cc05eCompareMay 20, 2018 10:43
@ohbarye

ohbarye commented May 20, 2018

Copy link
Copy Markdown
ContributorAuthor

@vsemozhetbyt Thanks for the review, I fixed typo and rebased commits.

@vsemozhetbyt

vsemozhetbyt commented May 20, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/14983/

@vsemozhetbyt

This comment has been minimized.

Sign in to view
@vsemozhetbyt

vsemozhetbyt commented May 20, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Rerun failed tasks:
https://ci.nodejs.org/job/node-test-commit-windows-fanned/18132/ (green)
https://ci.nodejs.org/job/node-test-commit-linux-containered/4570/ (green)
https://ci.nodejs.org/job/node-test-commit-linux/18903/ (strangely green with one fail)

mmarchini
mmarchini approved these changes May 21, 2018
View reviewed changes

@mmarchinimmarchini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: probably should update the commit message to Fixes: https://github.com/nodejs/node/issues/16459, otherwise I think the issue won't be closed.

@ohbarye
ohbaryeforce-pushed the add-prof-to-help-command branch from e3cc05e to 1e17a91CompareMay 21, 2018 14:17
@ohbarye

ohbarye commented May 21, 2018

Copy link
Copy Markdown
ContributorAuthor

@mmarchini
Thanks for pointing it out. I updated the commit message.

@vsemozhetbyt

vsemozhetbyt commented May 21, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/739/

@mmarchinimmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 21, 2018
jasnell pushed a commit that referenced this pull request May 23, 2018
@ohbarye@jasnell
src,doc: add doc of --prof flag to help command
9461f32
Fixes: #16459
PR-URL: #20845
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented May 23, 2018

Copy link
Copy Markdown
Member

Landed in 9461f32 with corrected metadata and revised commit message

@jasnelljasnell closed this May 23, 2018
@ohbarye

ohbarye commented May 23, 2018

Copy link
Copy Markdown
ContributorAuthor

Thank you node committers!

@ohbarye
ohbarye deleted the add-prof-to-help-command branch May 23, 2018 16:15
targos pushed a commit that referenced this pull request May 25, 2018
@ohbarye@targos
src,doc: add doc of --prof flag to help command
b0023d7
Fixes: #16459
PR-URL: #20845
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 29, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos left review comments
@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+2 more reviewers
@mmarchinimmarchinimmarchini approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.docIssues and PRs related to the documentations.performanceIssues and PRs related to the performance of Node.js.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--prof flag not documented in --help output

8 participants

@ohbarye@vsemozhetbyt@jasnell@targos@mmarchini@gireeshpunathil@BridgeAR@nodejs-github-bot