Uh oh!
There was an error while loading. Please reload this page.
net: remove unnecessary variables - #20864
Closed
chainhelen wants to merge 1 commit into
Closed
Conversation
apapirovski
approved these changes
May 21, 2018
BridgeAR
approved these changes
May 21, 2018
BridgeAR
commented
May 21, 2018
Member
jasnell
approved these changes
May 21, 2018
addaleax
approved these changes
May 21, 2018
TimothyGu
approved these changes
May 21, 2018
tniessen
approved these changes
May 21, 2018
lpinca
approved these changes
May 21, 2018
trivikr
approved these changes
May 21, 2018
danbev
approved these changes
May 22, 2018
tniessen
commented
May 22, 2018
Member
chainhelen
commented
May 22, 2018
ContributorAuthor
tniessen
commented
May 22, 2018
Member
@chainhelen Don't worry, it seems like there were a lot of unrelated failures, partially due to issues in our test infrastructure. As far as I can tell, no failures are related to your changes. One last CI before landing: https://ci.nodejs.org/job/node-test-pull-request/15021/ |
jasnell
commented
May 23, 2018
Member
Failure in CI is an unrelated flaky. |
jasnell pushed a commit
that referenced
this pull request
May 23, 2018
PR-URL: #20864 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell
commented
May 23, 2018
Member
Landed in ec39e62 |
targos pushed a commit
that referenced
this pull request
May 25, 2018
PR-URL: #20864 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove unnecessary variables
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes