Uh oh!
There was an error while loading. Please reload this page.
src: fix MallocedBuffer move assignment operator - #20883
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
addaleax
commented
May 22, 2018
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-commit/18669/ Feel free to 👍 this comment if you think fast-tracking makes sense. |
benjamingr
approved these changes
May 22, 2018
joyeecheung
approved these changes
May 22, 2018
cjihrig
approved these changes
May 22, 2018
jasnell
approved these changes
May 22, 2018
apapirovski
commented
May 23, 2018
Contributor
Last CI was troubled by infra problems: https://ci.nodejs.org/job/node-test-pull-request/15044/ |
tniessen
approved these changes
May 23, 2018
BridgeAR
commented
May 25, 2018
Member
Landed in cfc9d04 🎉 |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
May 25, 2018
PR-URL: nodejs#20883 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit
that referenced
this pull request
May 25, 2018
PR-URL: #20883 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #20876
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes