Uh oh!
There was an error while loading. Please reload this page.
test: show actual assertion error message with value - #20956
test: show actual assertion error message with value#20956thatshailesh wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Nit: I think the comment is not needed.
There was a problem hiding this comment.
Sure, Actually this is my first PR, and not sure why windows test failed
I am a mac user, is there anything I can do to fix it?
There was a problem hiding this comment.
The failure is unrelated, don't worry about that.
lpinca
commented
May 25, 2018
BridgeAR
commented
May 25, 2018
@thatshailesh would you be so kind and rebase? Seems like you accidentally added the latest commit and that has to be backed out again. |
thatshailesh
commented
May 25, 2018
@BridgeAR Sorry, I just did rebase, now only my commits are showing |
There was a problem hiding this comment.
How about this?:
process.nextTick(common.mustNotCall('process is exiting, should not be called'));Trott
commented
May 28, 2018
Looks like you may have accidentally included a package-lock.json update too? You can remove that change, I would think, or whoever is landing this can remove it. (The removed change will probably be the same change proposed in #20970.) |
on process exit if some assertion error occurs value of `process._exiting` was hidden, this fix will show the actual error message with value
thatshailesh
commented
May 28, 2018
@Trott ok I have removed it, thanks 👍 |
BridgeAR
commented
May 28, 2018
Landed in 8055bdb Congrats on your first contribution @thatshailesh! |
On process exit if some assertion error occurs value of `process._exiting` was hidden, this fix will show the actual error message with value. PR-URL: #20956 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
thatshailesh
commented
Jun 1, 2018
@apapirovski@Trott Thanks for the help 👍 |
On process exit if some assertion error occurs value of `process._exiting` was hidden, this fix will show the actual error message with value. PR-URL: #20956 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
on process exit if some assertion error occurs value of
process._exitingwas hidden, this fix will show the actual error message with value
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes