build,win: disable DLL-interface warnings

[piscisaureus]

Compiling node with vcbuild generates 10,000s of these warnings,
originating from v8.h. This makes it impossible to read any other
diagnostic messages.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows [commit guidelines]

[BridgeAR]

This came up before. See #15570

I guess we should indeed do this even though this should get fixed by Microsoft.

[piscisaureus]

@BridgeAR

Good to see that the root cause is being addressed.
But for the moment, this many warnings makes contributing to node a terrible experience.

Scrolling back in the terminal has become a thing of the past.
My browser crashes when I try to look at the CI output.

People can't work like that.

[BridgeAR]

I think it would be good to add a TODO to remove those two again as soon as it got fixed upstream. And please also open an issue at Microsoft https://developercommunity.visualstudio.com/spaces/62/index.html.

[BridgeAR]

@nodejs/build PTAL

[BridgeAR]

CI https://ci.nodejs.org/job/node-test-pull-request/15097/

[jasnell]

LGTM with a TODO as suggested

[richardlau]

No objections, but just noting that since this is common.gypi we'll also be suppressing these for addons.

[piscisaureus]

@BridgeAR, @nodejs/build: Added the TODO item; PTAL.

[piscisaureus]

Note that I don't seem to have commit rights. Someone has to push the button for me.

[joyeecheung]

✔ Approvals: 4, 3 from TSC (jasnell, cjihrig, joyeecheung)
ℹ Last Full PR CI on 2018-05-25T11:36:20Z: https://ci.nodejs.org/job/node-test-pull-request/15097/
⚠ Commits were pushed after the last Full PR CI run:
⚠ - build,win: disable DLL-interface warnings
ℹ This PR was created on Fri May 25 2018 (weekday in UTC)
⚠ 2 hours left to land

The push button is not used in this repo. According to git-node there are 2 hours left to land this (we wait for 48 hours for PRs summited on UTC weekday so people can have time to weigh in).

[joyeecheung]

Landed in 4f28015, thanks!

[richardlau]

Note that I don't seem to have commit rights. Someone has to push the button for me.

@piscisaureus That's because you were moved to Collaborator Emeriti in #16173. I'd suggest asking @nodejs/TSC if you wish to be moved back to Collaborator status.

[richardlau]

I'd suggest asking @nodejs/TSC if you wish to be moved back to Collaborator status.

Should have been @nodejs/tsc.