Skip to content

doc: add jdalton to collaborators - #20968

Closed
jdalton wants to merge 1 commit into
nodejs:masterfrom
jdalton:jdd
Closed

doc: add jdalton to collaborators#20968
jdalton wants to merge 1 commit into
nodejs:masterfrom
jdalton:jdd

Conversation

@jdalton

@jdaltonjdalton commented May 25, 2018

Copy link
Copy Markdown
Member

Fixes: #20828

Checklist

@jdalton
jdalton requested a review from a team as a code ownerMay 25, 2018 18:32
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 25, 2018
@BridgeAR

BridgeAR commented May 25, 2018

Copy link
Copy Markdown
Member

Welcome :-)

@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 25, 2018
@jdaltonjdalton changed the title doc: add jddalton to collaboratorsdoc: add jdalton to collaboratorsMay 25, 2018
TimothyGu
TimothyGu approved these changes May 25, 2018
View reviewed changes

@TimothyGuTimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉!

ofrobots
ofrobots approved these changes May 25, 2018
View reviewed changes

@ofrobotsofrobots left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@jdalton

jdalton commented May 25, 2018

Copy link
Copy Markdown
MemberAuthor

Thank you!

(I currently still need the bits toggled to be able to spin up a CI run and-or merge).

vsemozhetbyt
vsemozhetbyt reviewed May 25, 2018
View reviewed changes
Comment threadREADME.md Outdated

@vsemozhetbytvsemozhetbytMay 25, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines seem to be in the wrong order) Screenshot:

1

@vsemozhetbytvsemozhetbyt added meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs. labels May 25, 2018
@addaleax

addaleax commented May 25, 2018

Copy link
Copy Markdown
Member

@jdalton Are you being onboarded by somebody at the moment? We usually open these PRs as part of that process – not that there’s anything wrong with this PR, but I think we want to wait with merging it until that occurs?

@addaleaxaddaleax removed the fast-track PRs that do not need to wait for 48 hours to land. label May 25, 2018
@BridgeAR

BridgeAR commented May 25, 2018

Copy link
Copy Markdown
Member

@addaleax I thought these PRs are always meant to be merged by the onboarded person. If there was no onboarding, that is of course not happening.

@jdalton

jdalton commented May 25, 2018

Copy link
Copy Markdown
MemberAuthor

We usually open these PRs as part of that process – not that there’s anything wrong with this PR, but I think we want to wait with merging it until that occurs?

That's cool. No one has contacted me yet for onboarding (so I figured I'd get the ball rolling).
I'm fine with waiting for the i's dotted and t's crossed of it all.

@richardlaurichardlau added the blocked PRs that are blocked by other issues or PRs. label May 25, 2018
@richardlau

richardlau commented May 25, 2018

Copy link
Copy Markdown
Member

I'm going to set blocked just to prevent anyone else merging (although by convention these PRs should only be merged by the onboarded person anyway). Obviously consider it unblocked when the onboarding occurs.

hiroppy
hiroppy approved these changes May 25, 2018
View reviewed changes

@hiroppyhiroppy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

mcollina
mcollina approved these changes May 26, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrottTrott removed the blocked PRs that are blocked by other issues or PRs. label May 28, 2018
@jdalton

jdalton commented May 28, 2018

Copy link
Copy Markdown
MemberAuthor

ci: https://ci.nodejs.org/job/node-test-pull-request/15121/

@jdalton

jdalton commented May 28, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in bb6b605

@jdaltonjdalton closed this May 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request May 28, 2018
@jdalton
doc: add jdalton to collaborators
bb6b605
PR-URL: nodejs#20968Fixes: nodejs#20828
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@jdalton
jdalton deleted the jdd branch May 28, 2018 04:43
@gireeshpunathil

gireeshpunathil commented May 28, 2018

Copy link
Copy Markdown
Member

post-closure LGTM!

@benjamingr

benjamingr commented May 28, 2018

Copy link
Copy Markdown
Member

Welcome aboard @jdalton !

MylesBorins pushed a commit that referenced this pull request May 29, 2018
@jdalton@MylesBorins
doc: add jdalton to collaborators
babc9da
PR-URL: #20968Fixes: #20828
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 29, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+5 more reviewers
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
@ofrobotsofrobotsofrobots approved these changes
@LekoLekoLeko approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
@hiroppyhiroppyhiroppy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nominating jdalton as collaborator

16 participants

@jdalton@BridgeAR@addaleax@richardlau@gireeshpunathil@benjamingr@mcollina@ofrobots@Leko@TimothyGu@tniessen@hiroppy@vsemozhetbyt@trivikr@Trott@nodejs-github-bot