Skip to content

src: remove unused private data member - #20974

Merged
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:del-unused-field
May 30, 2018
Merged

src: remove unused private data member#20974
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:del-unused-field

Conversation

@bnoordhuis

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 26, 2018
@joyeecheung

Copy link
Copy Markdown
Member

@joyeecheungjoyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2018
@jasnell
jasnell requested a review from ofrobotsMay 29, 2018 22:52
PR-URL: nodejs#20974
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@bnoordhuis
bnoordhuis deleted the del-unused-field branch May 30, 2018 13:02
@bnoordhuis

Copy link
Copy Markdown
MemberAuthor

Landed in bea6238.

@bnoordhuis
bnoordhuis merged commit bea6238 into nodejs:masterMay 30, 2018
addaleax pushed a commit that referenced this pull request May 31, 2018
PR-URL: #20974
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorinsMylesBorins mentioned this pull request Jun 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@bnoordhuis@joyeecheung@jasnell@addaleax@benjamingr@TimothyGu@cjihrig@tniessen@nodejs-github-bot