Skip to content

docs: remove invalid vm.Script arguments - #20984

Closed
SimenB wants to merge 1 commit into
nodejs:masterfrom
SimenB:patch-1
Closed

docs: remove invalid vm.Script arguments#20984
SimenB wants to merge 1 commit into
nodejs:masterfrom
SimenB:patch-1

Conversation

@SimenB

Copy link
Copy Markdown
Member

Closes#20982

Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels May 26, 2018
@vsemozhetbyt

Copy link
Copy Markdown
Contributor

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2018

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SimenB :)

@benjamingr

benjamingr commented May 27, 2018

Copy link
Copy Markdown
Member

Collaborators - if you would like to approve fast-tracking this change please 👍 this comment.

Edit: CI Green

@benjamingrbenjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2018
@TimothyGuTimothyGu removed the fast-track PRs that do not need to wait for 48 hours to land. label May 30, 2018
@apapirovski

Copy link
Copy Markdown
Contributor

Landed in 529b173

apapirovski pushed a commit that referenced this pull request Jun 1, 2018
PR-URL: #20984Fixes: #20982
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
PR-URL: #20984Fixes: #20982
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jun 6, 2018
@SimenB
SimenB deleted the patch-1 branch February 11, 2020 13:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vm.Script should support timeouts

14 participants

@SimenB@vsemozhetbyt@benjamingr@apapirovski@jasnell@lpinca@TimothyGu@targos@cjihrig@tniessen@devsnek@BridgeAR@trivikr@nodejs-github-bot