Skip to content

src: remove unused req_wrap-inl.h - #20996

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:remove-unused-req_wrap-inl-header
Closed

src: remove unused req_wrap-inl.h#20996
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:remove-unused-req_wrap-inl-header

Conversation

@danbev

Copy link
Copy Markdown
Contributor

This commit removes the inclusion of req_wrap-inl.h from
udp_wrap.h, and tty_wrap.cc as they are not used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This commit removes the inclusion of req_wrap-inl.h from
udp_wrap.h, and tty_wrap.cc as they are not used.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. tty Issues and PRs related to the tty subsystem. labels May 28, 2018
@danbev

Copy link
Copy Markdown
ContributorAuthor

@danbev

Copy link
Copy Markdown
ContributorAuthor
node-test-commit-linuxone failure looks unrelated

console output:

02:59:39 not ok 420 parallel/test-domain-timers02:59:39 ---02:59:39 duration_ms: 0.10402:59:39 severity: fail02:59:39 exitcode: 102:59:39 stack: |-02:59:39 Mismatched <anonymous> function calls. Expected exactly 2, actual 1.02:59:39 at Object.exports.mustCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:403:10)02:59:39 at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-domain-timers.js:29:29)02:59:39 at Module._compile (internal/modules/cjs/loader.js:702:30)02:59:39 at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)02:59:39 at Module.load (internal/modules/cjs/loader.js:612:32)02:59:39 at tryModuleLoad (internal/modules/cjs/loader.js:551:12)02:59:39 at Function.Module._load (internal/modules/cjs/loader.js:543:3)02:59:39 at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)02:59:39 at startup (internal/bootstrap/node.js:239:19)03:00:51 not ok 1980 async-hooks/test-zlib.zlib-binding.deflate # TODO : Fix flaky test03:00:51 ---03:00:51 duration_ms: 0.14003:00:51 severity: crashed03:00:51 exitcode: -1103:00:51 stack: |-
node-test-commit-windows-fanned failure looks unrelated

console output:

not ok 51 parallel/test-child-process-fork-net --- duration_ms: 0.324 severity: fail exitcode: 1 stack: |- PARENT: server listening CHILD: server listening CLIENT: connected PARENT: got connection CLIENT: connected CHILD: got connection CLIENT: closed CHILD: got connection CHILD: got connection CLIENT: closed CLIENT: connected CLIENT: connected CLIENT: closed CLIENT: closed PARENT: server closed testSocket, listening CHILD: got socket CLIENT: got data CLIENT: closed events.js:167 throw er; // Unhandled 'error' event ^ Error: write EPIPE at ChildProcess.target._send (internal/child_process.js:741:20) at ChildProcess.target.send (internal/child_process.js:625:19) at SocketListSend._request (internal/socket_list.js:20:16) at SocketListSend.close (internal/socket_list.js:40:10) at Server.close (net.js:1636:24) at Socket.<anonymous> (c:\workspace\node-test-binary-windows\test\parallel\test-child-process-fork-net.js:178:16) at Socket.emit (events.js:182:13) at TCP._handle.close [as _onclose] (net.js:596:12) Emitted 'error' event at: at process.nextTick (internal/child_process.js:745:39) at process._tickCallback (internal/process/next_tick.js:61:11) ...

@BridgeARBridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 28, 2018
@danbev

Copy link
Copy Markdown
ContributorAuthor

Landed in c1a87a3.

@danbevdanbev closed this May 30, 2018
@danbev
danbev deleted the remove-unused-req_wrap-inl-header branch May 30, 2018 03:25
danbev added a commit that referenced this pull request May 30, 2018
This commit removes the inclusion of req_wrap-inl.h from
udp_wrap.h, and tty_wrap.cc as they are not used.
PR-URL: #20996
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request May 31, 2018
This commit removes the inclusion of req_wrap-inl.h from
udp_wrap.h, and tty_wrap.cc as they are not used.
PR-URL: #20996
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jun 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.dgramIssues and PRs related to the dgram subsystem / UDP.fast-trackPRs that do not need to wait for 48 hours to land.ttyIssues and PRs related to the tty subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@danbev@bnoordhuis@jasnell@cjihrig@BridgeAR@trivikr@nodejs-github-bot