Uh oh!
There was an error while loading. Please reload this page.
test: mark test-fs-readfile-tostring-fail as flaky - #21013
Closed
mmarchini wants to merge 2 commits into
Closed
Conversation
test-fs-readfile-tostring-fail is failing frequently on OSX machines. There's a PR to fix this issue in libuv, but while the fix don't land on Node.js this test should be marked as flaky. Ref: nodejs#16601 Ref: libuv/libuv#1742
mmarchini
commented
May 29, 2018
ContributorAuthor
mmarchini
commented
May 29, 2018
ContributorAuthor
Please leave a 👍 if you agree we should fast-track this |
BridgeAR
approved these changes
May 29, 2018
maclover7
approved these changes
May 29, 2018
maclover7
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but can you add a comment pointing to the libuv PR, saying that the test will be flaky until that PR lands
mmarchini
commented
May 29, 2018
ContributorAuthor
@maclover7 done! |
lpinca
approved these changes
May 29, 2018
apapirovski
approved these changes
May 29, 2018
jasnell
approved these changes
May 29, 2018
trivikr
approved these changes
May 29, 2018
jasnell
approved these changes
May 29, 2018
gireeshpunathil
approved these changes
May 30, 2018
MylesBorins
commented
May 30, 2018
Contributor
+1 to fast track |
mmarchini
commented
May 30, 2018
ContributorAuthor
Landed in 6d58479 |
mmarchini pushed a commit
that referenced
this pull request
May 30, 2018
test-fs-readfile-tostring-fail is failing frequently on OSX machines. There's a PR to fix this issue in libuv, but while the fix don't land on Node.js this test should be marked as flaky. Ref: #16601 Ref: libuv/libuv#1742 PR-URL: #21013 Refs: #16601 Refs: libuv/libuv#1742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit
that referenced
this pull request
May 31, 2018
test-fs-readfile-tostring-fail is failing frequently on OSX machines. There's a PR to fix this issue in libuv, but while the fix don't land on Node.js this test should be marked as flaky. Ref: #16601 Ref: libuv/libuv#1742 PR-URL: #21013 Refs: #16601 Refs: libuv/libuv#1742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-fs-readfile-tostring-fail is failing frequently on OSX machines.
There's a PR to fix this issue in libuv, but while the fix don't land on
Node.js this test should be marked as flaky.
Ref: #16601
Ref: libuv/libuv#1742
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes