Uh oh!
There was an error while loading. Please reload this page.
http2: force through RST_STREAM in destroy - #21016
Closed
apapirovski wants to merge 1 commit into
Closed
Conversation
If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream.
apapirovski
commented
May 29, 2018
ContributorAuthor
benjamingr
approved these changes
May 29, 2018
benjamingr
left a comment
Member
There was a problem hiding this comment.
Nice work diagnosing this from that one assertion failure!
Code, test and changes LGTM
jasnell
approved these changes
May 29, 2018
Member
Is http2 still considered experimental? Otherwise, maybe this fix might be semi-urgent to get out? |
apapirovski
commented
May 30, 2018
ContributorAuthor
Trott
commented
May 31, 2018
Member
Re-running windows-fanned: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18404/ Re-running osx: https://ci.nodejs.org/job/node-test-commit-osx/18959/ Re-running smartos: https://ci.nodejs.org/job/node-test-commit-smartos/18018/ |
addaleax
approved these changes
Jun 1, 2018
apapirovski
commented
Jun 1, 2018
ContributorAuthor
Landed in 35858bb |
apapirovski added a commit
that referenced
this pull request
Jun 1, 2018
If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream. PR-URL: #21016Fixes: #21008 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit
that referenced
this pull request
Jun 1, 2018
If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream. PR-URL: #21016Fixes: #21008 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
kjin pushed a commit
to kjin/node
that referenced
this pull request
Aug 23, 2018
If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream. PR-URL: nodejs#21016Fixes: nodejs#21008 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
kjin pushed a commit
to kjin/node
that referenced
this pull request
Sep 25, 2018
If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream. PR-URL: nodejs#21016Fixes: nodejs#21008 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
kjin pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream. PR-URL: nodejs#21016Fixes: nodejs#21008 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit
that referenced
this pull request
Oct 17, 2018
If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream. Backport-PR-URL: #22850 PR-URL: #21016Fixes: #21008 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If still needed, force through RST_STREAM in Http2Stream#destroy calls, so that nghttp2 can wrap up properly and doesn't continue trying to read & write data to the stream.
Fixes: #21008
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes